mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: K Prateek Nayak <kprateek.nayak@amd.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	linux-kernel@vger.kernel.org, kernel-team@meta.com,
	David Vernet <void@manifault.com>
Subject: Re: [PATCH tip/sched/core] sched/fair: Make balance_fair() test sched_fair_runnable() instead of rq->nr_running
Date: Mon, 5 Aug 2024 08:03:21 -1000	[thread overview]
Message-ID: <ZrET6XFqxkMYjVpY@slm.duckdns.org> (raw)
In-Reply-To: <0b8d4584-6ca2-f810-16fb-e989a0723bdc@amd.com>

Hello,

On Mon, Aug 05, 2024 at 08:51:05AM +0530, K Prateek Nayak wrote:
...
> When does this happen exactly? throttle_cfs_rq() calls sub_nr_running()
> negating the "h_nr_running" of the throttled entity from the
> rq->nr_running. Even deadline entities on being throttled dequeue the
> entity (or don't enqueue them at all in enqueue_dl_entity()) and would
> have the correct "rq->nr_running". Could you please highlight the path
> that might hit this scenario?

I just missed the sub_nr_running() call. No wonder I couldn't see behavior
difference. I'll redo the patch description.

Thanks.

-- 
tejun

  reply	other threads:[~2024-08-05 18:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-03  1:21 Tejun Heo
2024-08-05  3:21 ` K Prateek Nayak
2024-08-05 18:03   ` Tejun Heo [this message]
2024-08-05 22:39 ` [PATCH v2 sched_ext/for-6.12] " Tejun Heo
2024-08-06  1:37   ` Chengming Zhou
2024-08-06  5:26   ` K Prateek Nayak
2024-08-07 10:51   ` [tip: sched/core] " tip-bot2 for Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZrET6XFqxkMYjVpY@slm.duckdns.org \
    --to=tj@kernel.org \
    --cc=kernel-team@meta.com \
    --cc=kprateek.nayak@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=void@manifault.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®