From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E50C21BE867 for ; Tue, 6 Aug 2024 13:16:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722950176; cv=none; b=jzU4vOJOxXonR73v/b12Dc13qtGIfYRLxz4tvRT3wY8h4JMcciuDJUooD7+fKYThKeyRmaR2nuKdmld+fvqawhXSqaQpDbaueE0YNWB+wJWq5tL7bhlOaJAOHNAJ05W3Ah9Ffxp1kXdDDR/PwImT7q7TjDo3l3vjAOM2BB+uxwA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722950176; c=relaxed/simple; bh=WxVMOsooydwCvFTMcLilfNoUBQmZvwH9joUgNdC0h5A=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=bi5a/KwCmNMSCIrB2iVMP/TNAaz24XdYLivIghHDG9I+q69DB+M/ppOFeCY2/xsyh2KPcYQNQJMHxgfs7BkoyCgKId1JFkSHmZSUAAN8mEj3Jxf1FB3ADky/Dpc8eUbBu1JjoBXrDCCVY5rBd5pNrkeVuH5qETCMAaA/hhov/jc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sbK2d-0000GH-3S; Tue, 06 Aug 2024 15:15:55 +0200 Received: from [2a0a:edc0:2:b01:1d::c5] (helo=pty.whiteo.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sbK2b-004xsB-NF; Tue, 06 Aug 2024 15:15:53 +0200 Received: from ore by pty.whiteo.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1sbK2b-0051Ir-1q; Tue, 06 Aug 2024 15:15:53 +0200 Date: Tue, 6 Aug 2024 15:15:53 +0200 From: Oleksij Rempel To: Krzysztof Kozlowski Cc: Maxime Coquelin , Alexandre Torgue , Rob Herring , Krzysztof Kozlowski , Conor Dooley , David Jander , kernel@pengutronix.de, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH v1] arm: dts: st: Add MECIO1 and MECT1S board variants Message-ID: References: <20240806120332.405064-1-o.rempel@pengutronix.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org On Tue, Aug 06, 2024 at 02:39:31PM +0200, Krzysztof Kozlowski wrote: > On 06/08/2024 14:03, Oleksij Rempel wrote: > > From: David Jander > > > > Introduce device tree support for the MECIO1 and MECT1S board variants. > > MECIO1 is an I/O and motor control board used in blood sample analysis > > machines. MECT1S is a 1000Base-T1 switch for internal machine networks > > of blood sample analysis machines. > > > > Signed-off-by: David Jander > > Signed-off-by: Oleksij Rempel > > --- > > .../devicetree/bindings/arm/stm32/stm32.yaml | 8 + > > arch/arm/boot/dts/st/Makefile | 3 + > > arch/arm/boot/dts/st/stm32mp151c-mecio1r0.dts | 48 ++ > > arch/arm/boot/dts/st/stm32mp151c-mect1s.dts | 297 ++++++++++ > > arch/arm/boot/dts/st/stm32mp153c-mecio1r1.dts | 48 ++ > > .../arm/boot/dts/st/stm32mp15x-mecio1-io.dtsi | 533 ++++++++++++++++++ > > 6 files changed, 937 insertions(+) > > create mode 100644 arch/arm/boot/dts/st/stm32mp151c-mecio1r0.dts > > create mode 100644 arch/arm/boot/dts/st/stm32mp151c-mect1s.dts > > create mode 100644 arch/arm/boot/dts/st/stm32mp153c-mecio1r1.dts > > create mode 100644 arch/arm/boot/dts/st/stm32mp15x-mecio1-io.dtsi > > > > diff --git a/Documentation/devicetree/bindings/arm/stm32/stm32.yaml b/Documentation/devicetree/bindings/arm/stm32/stm32.yaml > > index 58099949e8f3a..703d4b574398d 100644 > > --- a/Documentation/devicetree/bindings/arm/stm32/stm32.yaml > > +++ b/Documentation/devicetree/bindings/arm/stm32/stm32.yaml > > Please run scripts/checkpatch.pl and fix reported warnings. Then please > run `scripts/checkpatch.pl --strict` and (probably) fix more warnings. Ack, I see. stm32.yaml should be in separate patch. > Some warnings can be ignored, especially from --strict run, but the code > here looks like it needs a fix. Feel free to get in touch if the warning > is not clear. What should be done with "ethernet-phy-id2000.a284" appears un-documente warnings? Should it be handled by Documentation/devicetree/bindings/net/ethernet-phy.yaml? Best regards, Oleksij -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |