From: Tejun Heo <tj@kernel.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: void@manifault.com, linux-kernel@vger.kernel.org,
kernel-team@meta.com, mingo@redhat.com
Subject: Re: [PATCH 6/6] sched_ext: Make task_can_run_on_remote_rq() use common task_allowed_on_cpu()
Date: Tue, 6 Aug 2024 07:04:09 -1000 [thread overview]
Message-ID: <ZrJXiU5H11_qzbZl@slm.duckdns.org> (raw)
In-Reply-To: <20240806081259.GN37996@noisy.programming.kicks-ass.net>
On Tue, Aug 06, 2024 at 10:12:59AM +0200, Peter Zijlstra wrote:
> > +extern inline bool task_allowed_on_cpu(struct task_struct *p, int cpu)
>
> This wants to be "static inline". no? I think we try and avoid "extern
> inline".
Oh yeah, definitely. Will fix it up.
Thanks.
--
tejun
next prev parent reply other threads:[~2024-08-06 17:04 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-04 2:40 [PATCHSET sched_ext/for-6.12] sched_ext: Misc updates Tejun Heo
2024-08-04 2:40 ` [PATCH 1/6] sched_ext: Simplify scx_can_stop_tick() invocation in sched_can_stop_tick() Tejun Heo
2024-08-05 17:55 ` David Vernet
2024-08-04 2:40 ` [PATCH 2/6] sched_ext: Add scx_enabled() test to @start_class promotion in put_prev_task_balance() Tejun Heo
2024-08-05 17:57 ` David Vernet
2024-08-04 2:40 ` [PATCH 3/6] sched_ext: Use update_curr_common() in update_curr_scx() Tejun Heo
2024-08-05 18:23 ` David Vernet
2024-08-04 2:40 ` [PATCH 4/6] sched_ext: Simplify UP support by enabling sched_class->balance() in UP Tejun Heo
2024-08-05 19:49 ` David Vernet
2024-08-04 2:40 ` [PATCH 5/6] sched_ext: Improve comment on idle_sched_class exception in scx_task_iter_next_locked() Tejun Heo
2024-08-05 19:50 ` David Vernet
2024-08-04 2:40 ` [PATCH 6/6] sched_ext: Make task_can_run_on_remote_rq() use common task_allowed_on_cpu() Tejun Heo
2024-08-05 19:55 ` David Vernet
2024-08-06 8:12 ` Peter Zijlstra
2024-08-06 17:04 ` Tejun Heo [this message]
2024-08-06 19:39 ` [PATCH v2 " Tejun Heo
2024-08-06 8:13 ` [PATCHSET sched_ext/for-6.12] sched_ext: Misc updates Peter Zijlstra
2024-08-06 19:39 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZrJXiU5H11_qzbZl@slm.duckdns.org \
--to=tj@kernel.org \
--cc=kernel-team@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=void@manifault.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®