From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB1B136AF2 for ; Wed, 7 Aug 2024 09:14:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723022043; cv=none; b=M8mkHIu1ukAZgyHmHiw+8N+rmbAiXuIaUyTmg1jn3mu3g0k9rwj+X2vmLjwXME9nCDPJmObGixSq4CPvXb9oCErOqplrPHAw+gtJL1hlouLgg+vZFrz08wiYny+r8+mOj+2bTIU8Z1ZP41EzejQyck1foWBWTSrwsFSIYsOkNy8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723022043; c=relaxed/simple; bh=DP6AmAs7OB7NrfQbUAU01mOamE1yKADeqYUvuV61lPU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=cH5FGXdHPFRfjx4mdnTJX/SCvUnYP7Enqf1lj6CkS8lbOTZ3pVeDGVswbvxTBj1G425ytIyuDBrXfcUpH0aisbj7xZvQXJ1VjP3KDrO3MEfd0P8YVLN+zHtf1swY8vpc1R4x0MHrm9m7rvVcxl4rBTtPCLTmHUKBsWM30UFD5IE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sbcjt-0006HJ-Sq; Wed, 07 Aug 2024 11:13:49 +0200 Received: from [2a0a:edc0:2:b01:1d::c5] (helo=pty.whiteo.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sbcjs-0059sm-P2; Wed, 07 Aug 2024 11:13:48 +0200 Received: from ore by pty.whiteo.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1sbcjs-006td3-26; Wed, 07 Aug 2024 11:13:48 +0200 Date: Wed, 7 Aug 2024 11:13:48 +0200 From: Oleksij Rempel To: Arnd Bergmann Cc: Kory Maincent , Jakub Kicinski , Kyle Swenson , Arnd Bergmann , "David S. Miller" , Eric Dumazet , Paolo Abeni , Thomas Petazzoni , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: pse-pd: tps23881: include missing bitfield.h header Message-ID: References: <20240807075455.2055224-1-arnd@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20240807075455.2055224-1-arnd@kernel.org> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Hi Arnd, Thank you for your patch. I acked already other one: https://lore.kernel.org/all/20240807071538.569784-1-guanjun@linux.alibaba.com/ On Wed, Aug 07, 2024 at 09:54:22AM +0200, Arnd Bergmann wrote: > From: Arnd Bergmann > > Using FIELD_GET() fails in configurations that don't already include > the header file indirectly: > > drivers/net/pse-pd/tps23881.c: In function 'tps23881_i2c_probe': > drivers/net/pse-pd/tps23881.c:755:13: error: implicit declaration of function 'FIELD_GET' [-Wimplicit-function-declaration] > 755 | if (FIELD_GET(TPS23881_REG_DEVID_MASK, ret) != TPS23881_DEVICE_ID) { > | ^~~~~~~~~ > > Fixes: 89108cb5c285 ("net: pse-pd: tps23881: Fix the device ID check") > Signed-off-by: Arnd Bergmann Regards, Oleksij -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |