From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BF40018DF62 for ; Fri, 9 Aug 2024 08:23:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723191822; cv=none; b=iWle4hc6jkVsePtPtJp7qdhhANbsZkh4n9AWbgpSORA5EfjsNdjh6fE68cpnBnmj39sVzml3B9mB3kbh+RM8Jp5qJD18bcXZdP/g1kRZdTzNREBm1yaa9szgTOiVchnxm5UuWd0XZAqYiziyliuyPyx/68BX5nN6+mZ0MYKs7t4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723191822; c=relaxed/simple; bh=No9zsEOOt5jN+jtC6WUt3ray/MqdMRvbuCF2qSdC1WY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=a8eFWDQWTgpCk9rRTZwL+5uKX6E0v/vF+anQij4cxdyhMWgtW6XcDnekl6jllbsLRYQi0UHkJyPSGIOMkcbenKcP3rTqtiCA2+5nHErs0fgMElidBYS5b5BVwo3Li3ox3GCMSA68nGtB3JSfb0a6k1KhtHH03jn3fv4Ouimrmqc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1scKuA-0006lg-NL; Fri, 09 Aug 2024 10:23:22 +0200 Received: from [2a0a:edc0:2:b01:1d::c5] (helo=pty.whiteo.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1scKu9-005cU3-LJ; Fri, 09 Aug 2024 10:23:21 +0200 Received: from sha by pty.whiteo.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1scKu9-00Ajnc-1l; Fri, 09 Aug 2024 10:23:21 +0200 Date: Fri, 9 Aug 2024 10:23:21 +0200 From: Sascha Hauer To: Kalle Valo Cc: Brian Norris , Francesco Dolcini , Yogesh Ashok Powar , Bing Zhao , "John W. Linville" , Amitkumar Karwar , Avinash Patil , Kiran Divekar , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de, stable@vger.kernel.org Subject: Re: [PATCH] mwifiex: duplicate static structs used in driver instances Message-ID: References: <20240809-mwifiex-duplicate-static-structs-v1-1-6837b903b1a4@pengutronix.de> <875xsai043.fsf@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <875xsai043.fsf@kernel.org> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org On Fri, Aug 09, 2024 at 11:14:36AM +0300, Kalle Valo wrote: > Sascha Hauer writes: > > > mwifiex_band_2ghz and mwifiex_band_5ghz are statically allocated, but > > used and modified in driver instances. Duplicate them before using > > them in driver instances so that different driver instances do not > > influence each other. > > > > This was observed on a board which has one PCIe and one SDIO mwifiex > > adapter. It blew up in mwifiex_setup_ht_caps(). This was called with > > the statically allocated struct which is modified in this function. > > > > Cc: stable@vger.kernel.org > > Fixes: d6bffe8bb520 ("mwifiex: support for creation of AP interface") > > Signed-off-by: Sascha Hauer > > Should this go to wireless tree for v6.11? Yes, that would be great. > > "wifi:" missing in subject but I can add that, no need to resend because > of this. Ok, thanks. I'll keep that in mind for the next patches. Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |