From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3D3721DFF5 for ; Fri, 9 Aug 2024 12:33:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723206819; cv=none; b=jTnRTwUlwFvyFqTq0AJEvWnizin/liVaONZzj+TP+jHKeAu00y5ginjNJGyKNXNOJph+V919CWmau4v1TSJxNVFfueQi250LcdVWIEOaG3A4MEhJpNSr5LUc4I7Ld3E2QEuaXhnxxgsNbqOo9qXhr1ieCop9IIThAcbkB6SfQRI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723206819; c=relaxed/simple; bh=BJKJmrIyCP3SUD+BWk9lsHhu3+psPUuG8xSNrtkvrro=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=HcY7gZHfk4IKOAUu2hh+CVf2cOO4pE/EhaCi1CG6qjOKzwnHerfFLoTQoNawLw7lZ7VdbEZp+wy0vxhkVgvGGGuseRchsvfbG10xET3N0w7B0oe73t89wH5ZGnPa7eFkebCRFS/AXKXNWk69j7uGmMPY1uI1/MQREUINZ30+G0A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org; spf=fail smtp.mailfrom=kernel.org; arc=none smtp.client-ip=198.175.65.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=kernel.org X-CSE-ConnectionGUID: 4LGf8BuzT6Kw//YsCVcTTA== X-CSE-MsgGUID: pLZeuPJVRYeyPzcOJiKzlg== X-IronPort-AV: E=McAfee;i="6700,10204,11158"; a="21519638" X-IronPort-AV: E=Sophos;i="6.09,276,1716274800"; d="scan'208";a="21519638" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Aug 2024 05:33:37 -0700 X-CSE-ConnectionGUID: Lf1gs+PFTeexB22+9418CA== X-CSE-MsgGUID: +zJVLFiAQPSjurjBYmlqeQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,276,1716274800"; d="scan'208";a="88193632" Received: from smile.fi.intel.com ([10.237.72.54]) by orviesa002.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Aug 2024 05:33:36 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.98) (envelope-from ) id 1scOoH-0000000DPpJ-1WUm; Fri, 09 Aug 2024 15:33:33 +0300 Date: Fri, 9 Aug 2024 15:33:33 +0300 From: Andy Shevchenko To: Zhang Ning Cc: gregkh@linuxfoundation.org, rafael@kernel.org, linux-kernel@vger.kernel.org, lee@kernel.org Subject: Re: mfd: intel_soc_pmic_bxtwc: irq 0 issue, tmu and typec components fail to probe. Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Fri, Aug 09, 2024 at 08:02:43PM +0800, Zhang Ning wrote: > Hi, Greg & Rafael > > recently, when I try to enable mfd components for intel_soc_pmic_bxtwc > for debian kernel[0]. I find tmu and typec failed to probe. > > after check source code, I find irq for these two devices are 0, when > use platform_get_irq, it will alway fail. > > if (WARN(!ret, "0 is an invalid IRQ number\n")) > return -EINVAL; > return ret; > > My workaround for debian is to hardcode irq to 0, instead to use api. > > I don't know how to write a good solution, thus send an email to you. Hold on, how the heck you got 0 in the first place? > [0]: https://salsa.debian.org/kernel-team/linux/-/merge_requests/1156/diffs -- With Best Regards, Andy Shevchenko