From: Herbert Xu <herbert@gondor.apana.org.au>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: oe-kbuild@lists.linux.dev,
"Linus Torvalds" <torvalds@linux-foundation.org>,
lkp@intel.com, oe-kbuild-all@lists.linux.dev,
LKML <linux-kernel@vger.kernel.org>,
"Russell King (Oracle)" <linux@armlinux.org.uk>,
"Horia Geantă" <horia.geanta@nxp.com>,
"Ard Biesheuvel" <ardb@kernel.org>,
linux-crypto@vger.kernel.org
Subject: Re: [PATCH 2/3] crypto: api - Do not wait for tests during registration
Date: Mon, 12 Aug 2024 18:33:13 +0800 [thread overview]
Message-ID: <Zrnk6Y8IDxmN99kG@gondor.apana.org.au> (raw)
In-Reply-To: <34069b9d-3731-4d0c-b317-bcbc61df7e9d@stanley.mountain>
On Sun, Aug 11, 2024 at 04:30:10PM +0300, Dan Carpenter wrote:
>
> c72358571aaadf Karim Eshapa 2017-05-13 368 pr_err("alg: Unexpected test result for %s: %d\n", name, err);
> 73d3864a4823ab Herbert Xu 2008-08-03 369 goto unlock;
>
> This calling crypto_alg_put() on the last item in the list seems wrong either
> way.
Indeed. This should just return.
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2024-08-12 10:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <ZrbTfOViUr3S4V7X@gondor.apana.org.au>
2024-08-11 13:30 ` Dan Carpenter
2024-08-12 10:33 ` Herbert Xu [this message]
2024-08-12 10:34 ` [v2 PATCH 1/3] crypto: api - Remove instance larval fulfilment Herbert Xu
2024-08-12 10:35 ` [v2 PATCH 2/3] crypto: api - Do not wait for tests during registration Herbert Xu
2024-08-12 10:36 ` [v2 PATCH 3/3] crypto: simd - Do not call crypto_alloc_tfm " Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zrnk6Y8IDxmN99kG@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=ardb@kernel.org \
--cc=dan.carpenter@linaro.org \
--cc=horia.geanta@nxp.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=oe-kbuild@lists.linux.dev \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®