From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C6E4415B55D for ; Wed, 28 Aug 2024 08:31:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724833893; cv=none; b=UOX2NljMiSYxbD77NmrwFrly9d4ee/41MANM6HEdQLYoXBCZ2Vr/jpMmze73AcayS43Vp9kWwaMM9a7yvSCB2JglDLqCXf5m2q6WsBKRXCNYiiKbNavUqc95LJizqeMXi2nBiLCUybEouiogwwDK2QTrmeaRX2NjEJcgRXxIxDQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724833893; c=relaxed/simple; bh=gjsYJdp7ScKwKcIE4Uu+ggF9Axf9/49wqI34k9cojGU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=c1j/4gLyUDcp+UaneQ2lPObDQ0ehEc3mVEsPngaOmseg7MTaW4kPrnEJHPy1IF76EWeO1xrpg9ejYkc9/SGtDFYo1zzD/xGR8eBwBjBVPjQk9QtI+7KxZAuCWwa/D1r3uYtG3Ir7l72YiK3GyQIEFW/pIlSVSKS51L6mLPa1QGo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Od8zZ/85; arc=none smtp.client-ip=209.85.218.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Od8zZ/85" Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-a86e9db75b9so199655566b.1 for ; Wed, 28 Aug 2024 01:31:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1724833889; x=1725438689; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=3c7NVkKcmxAMyio8/L9pzMWp9IJ9Pqc+LaOhJRGv9yg=; b=Od8zZ/856Oi5TpVaYDkGZl1v7MlQe3rFlqAlgbHVyhBtC3AVHUpmdIL9uoWs7Zo9NN C0nuKtBEDyzTsyNvFE5g21D9KdDAEC68W2xKO10WIOMAKx3at6fJxLgXF+x3S3wKkKgv GDCZD15PsJvI1pt1tZRT9Fd+4P1icFD8w86cos+6iUnsCSnfbpB38eqhFN3szRrZ7GvJ IZLyrpllE0i+06QLhXWIH4g1uC9FAHOHBmU6eMil/w9F5wOqQKGHJ1ZBp5OJLCTiPP57 c4XzMTtVG9zbZgZOxv2AjWc4aEupisZfBveJasUjec8PlYgrO9cj16QqxhXTDy57mvDf O8pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724833889; x=1725438689; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=3c7NVkKcmxAMyio8/L9pzMWp9IJ9Pqc+LaOhJRGv9yg=; b=qJpn2RydMVe7LEZwpxKoPOk4sE2wE7SG/hqyT5XJxoeueoUBj8lMzdClUbQ4WhgndQ +eGISaxeKhczLI1QmPkyxy2Ak1tEdn+xzp7I8ea+iNHQH1/5RWMAQvn5aqK8Z3kpLnly EPITqwUe08qXOqotHaECBCSFvjCmp2IEaK2+yvo4HaJoHwMJpfnqw+V6lgeQde2VTVyC FLFtlr8jf7ww6QAT/UH2cz74vEyTTV1O2uCUT5agyGchYTzzQFLdATTjXdHZcKJt8Xga uzVBYlLJVeSHEQP8y+fJ1+aGCMjnN+MFXsvgeImT4LwnRPpZUF5feoFmo5F8+5oSurVm izMg== X-Forwarded-Encrypted: i=1; AJvYcCXuStMKMoZotICEt501k/VHpjSDjr76jYCZDPOUMpfJ8E2iX1cOwpWOWLiAXOybXlL7pUdwcN8HD+oJQy8=@vger.kernel.org X-Gm-Message-State: AOJu0YxOQEELj9/SJC5498xAZmPTF5tT8skoo5UWWMCdvFmwBKogsMZH S2lHYcp0rB6t7x0eSMixYgC6iXQwPKbtM4fJswCTjpymKt6BLkgXqiiTgeOlj5k= X-Google-Smtp-Source: AGHT+IGObeLl3j0bnFYb8shzD2k1t7YBRB0S+K2t7vP1NBHH1oO3NjvEy1RtpFlfZhpgj6jiJ48fgA== X-Received: by 2002:a17:907:c0f:b0:a86:c111:cc35 with SMTP id a640c23a62f3a-a86c111cfb5mr901917966b.50.1724833888846; Wed, 28 Aug 2024 01:31:28 -0700 (PDT) Received: from linaro.org ([82.79.186.176]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a86e549d10fsm212595766b.54.2024.08.28.01.31.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Aug 2024 01:31:28 -0700 (PDT) Date: Wed, 28 Aug 2024 11:31:26 +0300 From: Abel Vesa To: Diogo Manuel Pais Silva Cc: Peng Fan , "abelvesa@kernel.org" , "linux-clk@vger.kernel.org" , "shawnguo@kernel.org" , "kernel@pengutronix.de" , "s.hauer@pengutronix.de" , "linux-arm-kernel@lists.infradead.org" , "sboyd@kernel.org" , "mturquette@baylibre.com" , "festevam@gmail.com" , "imx@lists.linux.dev" , "EMC: linux-kernel@vger.kernel.org" Subject: Re: [PATCH v2] clk: imx8qxp: Defer instead of failing probe Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On 24-07-02 08:10:44, Diogo Manuel Pais Silva wrote: > When of_clk_parent_fill is ran without all the parent clocks having been probed then the probe function will return -EINVAL, making it so that the probe isn't attempted again. As fw_devlink is on by default this does not usually happen, but if fw_devlink is disabled then it is very possible that the parent clock will be probed after the lpcg first attempt. > > Signed-off-by: Diogo Silva This patch doesn't apply cleanly. Please respin. Thanks! > --- > v2: change from dev_warn to dev_err_probe > --- > drivers/clk/imx/clk-imx8qxp-lpcg.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/clk/imx/clk-imx8qxp-lpcg.c b/drivers/clk/imx/clk-imx8qxp-lpcg.c > index d0ccaa040225..7bd9b745edbe 100644 > --- a/drivers/clk/imx/clk-imx8qxp-lpcg.c > +++ b/drivers/clk/imx/clk-imx8qxp-lpcg.c > @@ -225,8 +225,8 @@ static int imx_lpcg_parse_clks_from_dt(struct platform_device *pdev, > > ret = of_clk_parent_fill(np, parent_names, count); > if (ret != count) { > - dev_err(&pdev->dev, "failed to get clock parent names\n"); > - return count; > + return dev_err_probe(&pdev->dev, -EPROBE_DEFER, > + "failed to get all clock parent names\n"); > } > > ret = of_property_read_string_array(np, "clock-output-names", > -- > 2.34.1