From: Frank Li <Frank.li@nxp.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: robh@kernel.org, broonie@kernel.org, conor+dt@kernel.org,
devicetree@vger.kernel.org, imx@lists.linux.dev,
jdelvare@suse.com, krzk+dt@kernel.org, lgirdwood@gmail.com,
linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/1] dt-bindings: hwmon: Convert ltc2978.txt to yaml
Date: Wed, 28 Aug 2024 15:50:13 -0400 [thread overview]
Message-ID: <Zs9/dWVPri9hoCur@lizhi-Precision-Tower-5810> (raw)
In-Reply-To: <e0fc65c0-45b3-4948-bb00-f34db59fe011@roeck-us.net>
On Wed, Aug 28, 2024 at 12:40:59PM -0700, Guenter Roeck wrote:
> On 8/28/24 11:35, Frank Li wrote:
> > On Wed, Aug 28, 2024 at 10:06:25AM -0700, Guenter Roeck wrote:
> > > On 8/28/24 09:41, Frank Li wrote:
> > > > Convert binding doc ltc2978.txt to yaml format.
> > > > Additional change:
> > > > - add i2c node.
> > > > - basic it is regulator according to example, move it under regulator.
> > > >
> > > > Fix below warning:
> > > > arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-cx.dtb: /soc/i2c@2000000/i2c-mux@77/i2c@2/regulator@5c:
> > > > failed to match any schema with compatible: ['lltc,ltc3882']
> > > >
> > > > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > > > ---
> > > > Change from v3 to v4
> > > > - keep under hwmon directory.
> > > > Change from v2 to v3
> > > > - put my name into maintainers.
> > > > change from v1 to v2
> > > > - maintainer change to Mark Brown <broonie@kernel.org> (regulator maintainer)
> > > > - update title to (from ltc2978 data sheet).
> > > > octal, digital power-supply monitor, supervisor, sequencer, and margin controller.
> > > > ---
> > > > .../bindings/hwmon/lltc,ltc2972.yaml | 94 +++++++++++++++++++
> > > > .../devicetree/bindings/hwmon/ltc2978.txt | 62 ------------
> > >
> > > I still fail to understand the rationale for renaming the file from ltc2978
> > > to ltc2972. I can see that 2972 is currently the alphabetically first supported
> > > chip, but that is, in my opinion, irrelevant, and it will change.
> >
> > Conor suggest use one of compatbile string as filename. I random pick one.
> > I am not care about filename. If you like, I can use lltc,ltc2978.yaml
> > or other filename.
> >
>
> The rename results in a disconnect between driver name and the associated
> devicetree file. I fail to see the point of introducing that disconnect.
what's name do you prefered? lltc,ltc2978.yaml?
Frank
>
> Guenter
>
next prev parent reply other threads:[~2024-08-28 19:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-28 16:41 Frank Li
2024-08-28 17:06 ` Guenter Roeck
2024-08-28 18:35 ` Frank Li
2024-08-28 19:40 ` Guenter Roeck
2024-08-28 19:50 ` Frank Li [this message]
2024-08-28 20:21 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zs9/dWVPri9hoCur@lizhi-Precision-Tower-5810 \
--to=frank.li@nxp.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=imx@lists.linux.dev \
--cc=jdelvare@suse.com \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®