From: Frank Li <Frank.li@nxp.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Rob Herring <robh@kernel.org>, Jean Delvare <jdelvare@suse.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
"open list:HARDWARE MONITORING" <linux-hwmon@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
imx@lists.linux.dev
Subject: Re: [PATCH 1/1] dt-bindings: hwmon/regulator: Convert ltc2978.txt to yaml
Date: Fri, 16 Aug 2024 22:01:51 -0400 [thread overview]
Message-ID: <ZsAEj1k9liVfZgjp@lizhi-Precision-Tower-5810> (raw)
In-Reply-To: <71d341e0-d988-41a9-bf61-c691537749fc@roeck-us.net>
On Fri, Aug 16, 2024 at 05:03:16PM -0700, Guenter Roeck wrote:
> On 8/16/24 14:55, Rob Herring wrote:
> > On Wed, Aug 14, 2024 at 02:17:26PM -0400, Frank Li wrote:
> > > Convert binding doc ltc2978.txt to yaml format.
> > > Additional change:
> > > - add i2c node.
> > > - basic it is regulator according to example, move it under regulator.
> > >
> > > Fix below warning:
> > > arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-cx.dtb: /soc/i2c@2000000/i2c-mux@77/i2c@2/regulator@5c:
> > > failed to match any schema with compatible: ['lltc,ltc3882']
> > >
> > > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > > ---
> > > .../devicetree/bindings/hwmon/ltc2978.txt | 62 ------------
> > > .../bindings/regulator/lltc,ltc2972.yaml | 94 +++++++++++++++++++
> > > 2 files changed, 94 insertions(+), 62 deletions(-)
> > > delete mode 100644 Documentation/devicetree/bindings/hwmon/ltc2978.txt
> > > create mode 100644 Documentation/devicetree/bindings/regulator/lltc,ltc2972.yaml
> >
> > I'm on the fence whether to move this...
> >
>
> I don't really understand the rationale behind the move nor the rationale behind
> the rename, but then I don't really care or mind as long as no one claims that
> the _driver_ should be moved because the devicetree bindings moved.
Conor suggest use one of compatible string as file name.
I just help convert it. I am not familar with this chip at all.
According to original docuemnt, most talk about regular instead of hwmon.
If you want to keep it under hwmon, I am fine.
Frank
>
> Note that "basic it is a regulator" is a bit stretching. The driver's regulator
> functionality must be enabled with a separate configuration option; the driver
> works perfectly fine as hardware monitoring driver if SENSORS_LTC2978_REGULATOR=n.
>
> Guenter
>
next prev parent reply other threads:[~2024-08-17 2:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-14 18:17 Frank Li
2024-08-16 21:55 ` Rob Herring
2024-08-16 22:04 ` Mark Brown
2024-08-17 0:03 ` Guenter Roeck
2024-08-17 2:01 ` Frank Li [this message]
2024-08-17 3:34 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZsAEj1k9liVfZgjp@lizhi-Precision-Tower-5810 \
--to=frank.li@nxp.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=imx@lists.linux.dev \
--cc=jdelvare@suse.com \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®