From: Tejun Heo <tj@kernel.org>
To: Yipeng Zou <zouyipeng@huawei.com>
Cc: void@manifault.com, mingo@redhat.com, peterz@infradead.org,
juri.lelli@redhat.com, vincent.guittot@linaro.org,
linux-kernel@vger.kernel.org, dietmar.eggemann@arm.com,
rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de,
vschneid@redhat.com
Subject: Re: [PATCH] sched_ext: Allow dequeue_task_scx to fail
Date: Tue, 20 Aug 2024 09:09:37 -1000 [thread overview]
Message-ID: <ZsTp8WeKCmNavWXl@slm.duckdns.org> (raw)
In-Reply-To: <20240820024531.12781-1-zouyipeng@huawei.com>
On Tue, Aug 20, 2024 at 10:45:31AM +0800, Yipeng Zou wrote:
> Since dequeue_task() allowed to fail, there is a compile error:
>
> kernel/sched/ext.c:3630:19: error: initialization of ‘bool (*)(struct rq*, struct task_struct *, int)’ {aka ‘_Bool (*)(struct rq *, struct task_struct *, int)’} from incompatible pointer type ‘void (*)(struct rq*, struct task_struct *, int)’
> 3630 | .dequeue_task = dequeue_task_scx,
> | ^~~~~~~~~~~~~~~~
>
> Allow dequeue_task_scx to fail too.
>
> Fixes: 863ccdbb918a ("sched: Allow sched_class::dequeue_task() to fail")
> Signed-off-by: Yipeng Zou <zouyipeng@huawei.com>
Applied to sched_ext/for-6.12.
Thanks.
--
tejun
prev parent reply other threads:[~2024-08-20 19:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-20 2:45 Yipeng Zou
2024-08-20 19:09 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZsTp8WeKCmNavWXl@slm.duckdns.org \
--to=tj@kernel.org \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
--cc=void@manifault.com \
--cc=vschneid@redhat.com \
--cc=zouyipeng@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®