From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AA1571B250D for ; Wed, 21 Aug 2024 14:39:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724251197; cv=none; b=KjfoaaFYVlk6CoIHPsvbTgSmFdd1YquQC5T2QCQ/tetlN4m7AjOshBdw2eY0mYpDXNcGxctmo4BBUd+HHHPgVWzPXqrKsy2o+/ka8HC483b/H8jP9mH9ERBxR5fr+/QLLe/nIHyKJ00jGAUaEa298KbpvWVNV/FO6N9lQEF56Kk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724251197; c=relaxed/simple; bh=xMcCS+EBmuGaYl1JyAYde/ccZh6Tohl0Niv38BHitvs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Ynabgb0IHeZ9BWQke5sVBurNTEYlPe92galypjVuXJO7N9a7UJF3LEVMHBLzMOUOFfRNOtCRgTpWJuMKQ7evurOEcSKM/3D/h/iTTpIUOTXQeOrP7n2/mFPIrhM5U4N7EfzUiuS4ES+UwCxWPNBGQ2Pw1Mn6IvO9LPEmppAQ5VY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sgmUv-0001Z2-24; Wed, 21 Aug 2024 16:39:41 +0200 Received: from [2a0a:edc0:2:b01:1d::c5] (helo=pty.whiteo.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sgmUt-00227J-UZ; Wed, 21 Aug 2024 16:39:39 +0200 Received: from ore by pty.whiteo.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1sgmUt-00FXl6-2f; Wed, 21 Aug 2024 16:39:39 +0200 Date: Wed, 21 Aug 2024 16:39:39 +0200 From: Oleksij Rempel To: Fabio Estevam Cc: Stefan Eichenberger , kernel@pengutronix.de, andi.shyti@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, Frank.Li@nxp.com, francesco.dolcini@toradex.com, linux-i2c@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Stefan Eichenberger Subject: Re: [PATCH v2 1/4] i2c: imx: only poll for bus busy in multi master mode Message-ID: References: <20240819072052.8722-1-eichest@gmail.com> <20240819072052.8722-2-eichest@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Hi Fabio, Stefan, On Wed, Aug 21, 2024 at 08:01:20AM -0300, Fabio Estevam wrote: > Hi Stefan, > > On Mon, Aug 19, 2024 at 4:20 AM Stefan Eichenberger wrote: > > > > From: Stefan Eichenberger > > > > According to the i.MX8M Mini reference manual chapter "16.1.4.2 > > Generation of Start" it is only necessary to poll for bus busy and > > arbitration lost in multi master mode. This helps to avoid rescheduling > > while the i2c bus is busy and avoids SMBus devices to timeout. > > > > Signed-off-by: Stefan Eichenberger > > Reviewed-by: Frank Li > > This fixes a pca953x probe error on an imx8mp board running linux-stable 6.6: > > [ 1.893260] pca953x 2-0020: failed writing register > [ 1.898258] pca953x 2-0020: probe with driver pca953x failed with error -11 > > Could you please add a Fixes tag and Cc stable so that this can reach > the stable kernels? > > Tested-by: Fabio Estevam > > Thanks a lot, It looks like with this patch, the I2SR_IAL interrupt is not cleared. I would expect some kind of interrupt storm. Can you confirm it? Regards, Oleksij -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |