Re: [PATCH v2] media: rockchip: rga: fix rga offset lookup

[Michael Tretter <m.tretter@pengutronix.de>]

On Sat, 10 Aug 2024 14:02:54 +0100, John Keeping wrote:
> The arguments to rga_lookup_draw_pos() are passed in the wrong order,
> rotate mode should be before mirror mode.

Thanks for the patch!

> 
> Fixes: 558c248f930e6 ("media: rockchip: rga: split src and dst buffer setup")
> Signed-off-by: John Keeping <jkeeping@inmusicbrands.com>

Reviewed-by: Michael Tretter <m.tretter@pengutronix.de>

> ---
>  drivers/media/platform/rockchip/rga/rga-hw.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/platform/rockchip/rga/rga-hw.c b/drivers/media/platform/rockchip/rga/rga-hw.c
> index 11c3d72347572..b2ef3beec5258 100644
> --- a/drivers/media/platform/rockchip/rga/rga-hw.c
> +++ b/drivers/media/platform/rockchip/rga/rga-hw.c
> @@ -376,7 +376,7 @@ static void rga_cmd_set_dst_info(struct rga_ctx *ctx,
>  	 * Configure the dest framebuffer base address with pixel offset.
>  	 */
>  	offsets = rga_get_addr_offset(&ctx->out, offset, dst_x, dst_y, dst_w, dst_h);
> -	dst_offset = rga_lookup_draw_pos(&offsets, mir_mode, rot_mode);
> +	dst_offset = rga_lookup_draw_pos(&offsets, rot_mode, mir_mode);
>  
>  	dest[(RGA_DST_Y_RGB_BASE_ADDR - RGA_MODE_BASE_REG) >> 2] =
>  		dst_offset->y_off;
> -- 
> 2.46.0
> 
>