From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 460C7148308 for ; Mon, 26 Aug 2024 10:17:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724667454; cv=none; b=luZw06WvJ8dpGufWFS075YqQGyw+eHFPUb7FqUvDUedEJgc6r/uWilNpnejKKsnsmAS2GeP3VPslmpTkHDDEkeJoX0l/BqaCUb/hfUhU7ohQ218YfUXTkXrVT7YbaQ4/nCEEFA9mHTCVNykiKLbsg08lTmxlKHuLlX1wLh7EusE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724667454; c=relaxed/simple; bh=+1sSYTJpR0WMXuTFjr+JO8ZWGztuKrRMT2yUDdMrNi0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=SdcToISLjub62iWPCO5ryE82xjwIVt8ql+GQG1x6e0Z7LDfLSGFq+xbkc3QF1UCA75YyLQq88P6+s0L8KHKMclJVFmVaXXNqUpFdBOQWQo2HjGEOdKpFQJNx5OWeYvgQUc1PlspxtSmIbcXWPDTFidE2xEi6t4oBUhDNeuCKpgE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1siWmp-0007gb-3w; Mon, 26 Aug 2024 12:17:23 +0200 Received: from [2a0a:edc0:2:b01:1d::c5] (helo=pty.whiteo.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1siWmo-003AFu-A3; Mon, 26 Aug 2024 12:17:22 +0200 Received: from sha by pty.whiteo.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1siWmo-0072PO-0e; Mon, 26 Aug 2024 12:17:22 +0200 Date: Mon, 26 Aug 2024 12:17:22 +0200 From: Sascha Hauer To: David Lin Cc: Brian Norris , Francesco Dolcini , Kalle Valo , "linux-wireless@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "kernel@pengutronix.de" , Pete Hsieh Subject: Re: [EXT] [PATCH 10/31] wifi: mwifiex: fix indention Message-ID: References: <20240820-mwifiex-cleanup-v1-0-320d8de4a4b7@pengutronix.de> <20240820-mwifiex-cleanup-v1-10-320d8de4a4b7@pengutronix.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org On Mon, Aug 26, 2024 at 09:48:38AM +0000, David Lin wrote: > > From: Sascha Hauer > > Sent: Monday, August 26, 2024 5:37 PM > > To: David Lin > > Cc: Brian Norris ; Francesco Dolcini > > ; Kalle Valo ; > > linux-wireless@vger.kernel.org; linux-kernel@vger.kernel.org; > > kernel@pengutronix.de > > Subject: Re: [EXT] [PATCH 10/31] wifi: mwifiex: fix indention > > > > Caution: This is an external email. Please take care when clicking links or > > opening attachments. When in doubt, report the message using the 'Report > > this email' button > > > > > > On Thu, Aug 22, 2024 at 09:36:29AM +0000, David Lin wrote: > > > > From: Sascha Hauer > > > > Sent: Tuesday, August 20, 2024 7:56 PM > > > > To: Brian Norris ; Francesco Dolcini > > > > ; Kalle Valo > > > > Cc: linux-wireless@vger.kernel.org; linux-kernel@vger.kernel.org; > > > > kernel@pengutronix.de; Sascha Hauer > > > > Subject: [EXT] [PATCH 10/31] wifi: mwifiex: fix indention > > > > > > > > Align multiline if() under the opening brace. > > > > > > > > Signed-off-by: Sascha Hauer > > > > --- > > > > drivers/net/wireless/marvell/mwifiex/wmm.c | 12 ++++++------ > > > > 1 file changed, 6 insertions(+), 6 deletions(-) > > > > > > > > diff --git a/drivers/net/wireless/marvell/mwifiex/wmm.c > > > > b/drivers/net/wireless/marvell/mwifiex/wmm.c > > > > index bcb61dab7dc86..1b1222c73728f 100644 > > > > --- a/drivers/net/wireless/marvell/mwifiex/wmm.c > > > > +++ b/drivers/net/wireless/marvell/mwifiex/wmm.c > > > > @@ -1428,13 +1428,13 @@ mwifiex_dequeue_tx_packet(struct > > > > mwifiex_adapter *adapter) > > > > } > > > > > > > > if (!ptr->is_11n_enabled || > > > > - ptr->ba_status || > > > > - priv->wps.session_enable) { > > > > + ptr->ba_status || > > > > + priv->wps.session_enable) { > > > > if (ptr->is_11n_enabled && > > > > - ptr->ba_status && > > > > - ptr->amsdu_in_ampdu && > > > > - mwifiex_is_amsdu_allowed(priv, tid) && > > > > - mwifiex_is_11n_aggragation_possible(priv, > > ptr, > > > > + ptr->ba_status && > > > > + ptr->amsdu_in_ampdu && > > > > + mwifiex_is_amsdu_allowed(priv, tid) && > > > > + mwifiex_is_11n_aggragation_possible(priv, ptr, > > > > > > > > adapter->tx_buf_size)) > > > > mwifiex_11n_aggregate_pkt(priv, ptr, > > ptr_index); > > > > /* ra_list_spinlock has been freed in > > > > > > > > -- > > > > 2.39.2 > > > > > > > > > > I wonder we still need patch for indent issue here? If so I am sure we > > > will need a bunch of similar patches which I don't think really help > > > improve mwifiex quality > > > > > > Actually in its successor Nxpwifi (currently under review), we have > > > cleaned up all indent, and checkpatch errors/warnings/checks. > > > > BTW you advertised nxpwifi not as a successor to mwifiex, but as the driver to > > be used for new chips. This means we still have to deal with the mwifiex driver > > in the future to support the old chips, so even if nxpwifi is merged it still makes > > sense to clean up mwifiex. > > > > Sascha > > > > Just like what I listed for the errors/warning/checks of Mwifiex running with checkpatch. > Mwifiex has so many issues. As the driver will only support legacy devices and the state of > it is "Odd fixes", It is better to fix really bugs of Mwifiex instead of cleanup it. The way you use "legacy" is from a silicon vendors perspective. Many real users only start to use a chip when it's already legacy for the silicon vendor. Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |