From: Richard Cochran <richardcochran@gmail.com>
To: Jinjie Ruan <ruanjinjie@huawei.com>
Cc: bryan.whitehead@microchip.com, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
anna-maria@linutronix.de, frederic@kernel.org,
tglx@linutronix.de, UNGLinuxDriver@microchip.com, mbenes@suse.cz,
jstultz@google.com, andrew@lunn.ch, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next v3 1/2] posix-timers: Check timespec64 before call clock_set()
Date: Mon, 9 Sep 2024 08:19:49 -0700 [thread overview]
Message-ID: <Zt8SFUpFp7JDkNbM@hoboy.vegasvil.org> (raw)
In-Reply-To: <20240909074124.964907-2-ruanjinjie@huawei.com>
On Mon, Sep 09, 2024 at 03:41:23PM +0800, Jinjie Ruan wrote:
> diff --git a/kernel/time/posix-timers.c b/kernel/time/posix-timers.c
> index 1cc830ef93a7..34deec619e17 100644
> --- a/kernel/time/posix-timers.c
> +++ b/kernel/time/posix-timers.c
> @@ -1137,6 +1137,9 @@ SYSCALL_DEFINE2(clock_settime, const clockid_t, which_clock,
> if (get_timespec64(&new_tp, tp))
> return -EFAULT;
>
> + if (!timespec64_valid(&new_tp))
> + return -ERANGE;
Why not use timespec64_valid_settod()?
Thanks,
Richard
next prev parent reply other threads:[~2024-09-09 15:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-09 7:41 [PATCH -next v3 0/2] " Jinjie Ruan
2024-09-09 7:41 ` [PATCH -next v3 1/2] " Jinjie Ruan
2024-09-09 15:19 ` Richard Cochran [this message]
2024-09-10 11:23 ` Jinjie Ruan
2024-09-10 12:05 ` Thomas Gleixner
2024-09-10 12:30 ` Jinjie Ruan
2024-09-10 15:48 ` Thomas Gleixner
2024-09-12 2:53 ` Jinjie Ruan
2024-09-12 12:04 ` Thomas Gleixner
2024-09-12 12:24 ` Jinjie Ruan
2024-09-13 10:46 ` Thomas Gleixner
2024-09-14 9:00 ` Jinjie Ruan
2024-09-09 7:41 ` [PATCH -next v3 2/2] net: lan743x: Remove duplicate check Jinjie Ruan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zt8SFUpFp7JDkNbM@hoboy.vegasvil.org \
--to=richardcochran@gmail.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=anna-maria@linutronix.de \
--cc=bryan.whitehead@microchip.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=frederic@kernel.org \
--cc=jstultz@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=ruanjinjie@huawei.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®