From: Francesco Dolcini <francesco@dolcini.it>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Brian Norris <briannorris@chromium.org>,
Francesco Dolcini <francesco@dolcini.it>,
Kalle Valo <kvalo@kernel.org>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 12/12] wifi: mwifiex: drop asynchronous init waiting code
Date: Mon, 9 Sep 2024 19:14:11 +0200 [thread overview]
Message-ID: <Zt8s4xEun6VL-pHW@gaggiata.pivistrello.it> (raw)
In-Reply-To: <20240826-mwifiex-cleanup-1-v1-12-56e6f8e056ec@pengutronix.de>
On Mon, Aug 26, 2024 at 01:01:33PM +0200, Sascha Hauer wrote:
> Historically all commands sent to the mwifiex driver have been
> asynchronous. For this reason there is code that waits for the
> last initialization command to complete before going on. Nowadays the
> commands can be sent synchronously, meaning that they are completed
> when the command call returns. This makes all the waiting code
> unnecessary. It is removed in this patch.
I am not sure to understand this. Is the code to have asynchronous command gone
or it is just not used anymore? In the code here you remove waiting for the
firmware init to be complete, but from the patch is not clear why this is not
needed anymore. Maybe a specific commit you can reference in which such
support was removed?
next prev parent reply other threads:[~2024-09-09 17:14 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-26 11:01 [PATCH 00/12] mwifiex: two fixes and cleanup Sascha Hauer
2024-08-26 11:01 ` [PATCH 01/12] wifi: mwifiex: add missing locking Sascha Hauer
2024-08-27 11:55 ` Francesco Dolcini
2024-09-02 6:30 ` [EXT] " David Lin
2024-08-26 11:01 ` [PATCH 02/12] wifi: mwifiex: fix MAC address handling Sascha Hauer
2024-09-06 14:40 ` Francesco Dolcini
2024-09-09 8:09 ` Sascha Hauer
2024-09-09 16:42 ` Francesco Dolcini
2024-08-26 11:01 ` [PATCH 03/12] wifi: mwifiex: deduplicate code in mwifiex_cmd_tx_rate_cfg() Sascha Hauer
2024-09-06 14:54 ` Francesco Dolcini
2024-08-26 11:01 ` [PATCH 04/12] wifi: mwifiex: use adapter as context pointer for mwifiex_hs_activated_event() Sascha Hauer
2024-09-06 15:03 ` Francesco Dolcini
2024-08-26 11:01 ` [PATCH 05/12] wifi: mwifiex: drop unnecessary initialization Sascha Hauer
2024-09-06 15:07 ` Francesco Dolcini
2024-08-26 11:01 ` [PATCH 06/12] wifi: mwifiex: make region_code_mapping_t const Sascha Hauer
2024-09-06 15:08 ` Francesco Dolcini
2024-08-26 11:01 ` [PATCH 07/12] wifi: mwifiex: pass adapter to mwifiex_dnld_cmd_to_fw() Sascha Hauer
2024-09-06 15:11 ` Francesco Dolcini
2024-08-26 11:01 ` [PATCH 08/12] wifi: mwifiex: simplify mwifiex_setup_ht_caps() Sascha Hauer
2024-09-09 17:04 ` Francesco Dolcini
2024-08-26 11:01 ` [PATCH 09/12] wifi: mwifiex: fix indention Sascha Hauer
2024-09-06 15:15 ` Francesco Dolcini
2024-08-26 11:01 ` [PATCH 10/12] wifi: mwifiex: make locally used function static Sascha Hauer
2024-09-06 15:16 ` Francesco Dolcini
2024-08-26 11:01 ` [PATCH 11/12] wifi: mwifiex: move common settings out of switch/case Sascha Hauer
2024-09-09 17:09 ` Francesco Dolcini
2024-09-09 20:21 ` Sascha Hauer
2024-09-09 20:55 ` Francesco Dolcini
2024-08-26 11:01 ` [PATCH 12/12] wifi: mwifiex: drop asynchronous init waiting code Sascha Hauer
2024-09-09 17:14 ` Francesco Dolcini [this message]
2024-09-09 20:14 ` Sascha Hauer
2024-09-10 8:30 ` Francesco Dolcini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zt8s4xEun6VL-pHW@gaggiata.pivistrello.it \
--to=francesco@dolcini.it \
--cc=briannorris@chromium.org \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®