From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: Xi Ruoyao <xry111@xry111.site>
Cc: Jiaxun Yang <jiaxun.yang@flygoat.com>,
linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mips: Remove posix_types.h include from sigcontext.h
Date: Thu, 29 Aug 2024 10:49:14 +0200 [thread overview]
Message-ID: <ZtA2CjzGY9CK6jPh@alpha.franken.de> (raw)
In-Reply-To: <20240828030413.143930-2-xry111@xry111.site>
On Wed, Aug 28, 2024 at 11:04:14AM +0800, Xi Ruoyao wrote:
> Nothing in sigcontext.h seems to require anything from
> linux/posix_types.h.
>
> It seems only a relict: in a Linux 2.6.11-rc2 patch [1] the
> linux/types.h include was unexplainedly changed to a linux/posix_types.h
> include. I can only assume it was just an error. Finally headers_check
> complained "found __[us]{8,16,32,64} type without #include
> <linux/types.h>" and commit ae612fb05b0f ("headers_check fix: mips,
> sigcontext.h") added back the linux/types.h include, but it didn't
> remove the posix_types.h include.
>
> Remove it now.
>
> [1]:https://kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.11-rc2/2.6.11-rc2-mm2/broken-out/mips-generic-mips-updates.patch
>
> Signed-off-by: Xi Ruoyao <xry111@xry111.site>
> ---
> arch/mips/include/uapi/asm/sigcontext.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/mips/include/uapi/asm/sigcontext.h b/arch/mips/include/uapi/asm/sigcontext.h
> index d0a540e88bb4..d10afd13ee5b 100644
> --- a/arch/mips/include/uapi/asm/sigcontext.h
> +++ b/arch/mips/include/uapi/asm/sigcontext.h
> @@ -56,7 +56,6 @@ struct sigcontext {
>
> #if _MIPS_SIM == _MIPS_SIM_ABI64 || _MIPS_SIM == _MIPS_SIM_NABI32
>
> -#include <linux/posix_types.h>
> /*
> * Keep this struct definition in sync with the sigcontext fragment
> * in arch/mips/kernel/asm-offsets.c
> --
> 2.46.0
applied to mips-next.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
next prev parent reply other threads:[~2024-08-29 8:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-28 3:04 Xi Ruoyao
2024-08-29 8:49 ` Thomas Bogendoerfer [this message]
2024-09-04 2:06 ` Maciej W. Rozycki
2024-09-04 10:02 ` Xi Ruoyao
2024-09-04 12:49 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZtA2CjzGY9CK6jPh@alpha.franken.de \
--to=tsbogend@alpha.franken.de \
--cc=jiaxun.yang@flygoat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=xry111@xry111.site \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®