mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@denx.de>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Pavel Machek <pavel@denx.de>,
	stable@vger.kernel.org, patches@lists.linux.dev,
	linux-kernel@vger.kernel.org, torvalds@linux-foundation.org,
	akpm@linux-foundation.org, linux@roeck-us.net, shuah@kernel.org,
	patches@kernelci.org, lkft-triage@lists.linaro.org,
	jonathanh@nvidia.com, f.fainelli@gmail.com,
	sudipm.mukherjee@gmail.com, srw@sladewatkins.net, rwarsow@gmx.de,
	conor@kernel.org, allen.lkml@gmail.com, broonie@kernel.org,
	kuba@kernel.org, linan122@huawei.com, dsterba@suse.com,
	song@kernel.org, tglx@linutronix.de, viro@zeniv.linux.org.uk,
	christian.brauner@ubuntu.com, keescook@chromium.org
Subject: Re: [PATCH 6.1 000/321] 6.1.107-rc1 review
Date: Thu, 29 Aug 2024 14:11:57 +0200	[thread overview]
Message-ID: <ZtBljcXHrUdvglG0@duo.ucw.cz> (raw)
In-Reply-To: <2024082954-direction-gonad-7fa2@gregkh>

[-- Attachment #1: Type: text/plain, Size: 2095 bytes --]

On Thu 2024-08-29 13:52:59, Greg Kroah-Hartman wrote:
> On Thu, Aug 29, 2024 at 01:37:40PM +0200, Pavel Machek wrote:
> > > Christian Brauner <brauner@kernel.org>
> > >     binfmt_misc: cleanup on filesystem umount
> > 
> > Changelog explains how this may cause problems. It does not fix a
> > bug. It is overly long. It does not have proper signoff by stable team.
> 
> The sign off is there, it's just further down than you might expect.

Is it? Who signed this off for stable?

cf7602cbd58246d02a8544e4f107658fe846137a

    In line with our general policy, if we see a regression for systemd or
    other users with this change we will switch back to the old behavior for
    the initial binfmt_misc mount and have binary types pin the filesystem
    again. But while we touch this code let's take the chance and let's
    improve on the status quo.
    
    [1]: https://lore.kernel.org/r/20191216091220.465626-2-laurent@vivier.eu
    [2]: commit 43a4f2619038 ("exec: binfmt_misc: fix race between load_misc_binary() and kill_node()"
    [3]: commit 83f918274e4b ("exec: binfmt_misc: shift filp_close(interp_file) from kill_node() to bm_evict_inode()")
    [4]: commit f0fe2c0f050d ("binder: prevent UAF for binderfs devices II")
    
    Link: https://lore.kernel.org/r/20211028103114.2849140-1-brauner@kernel.org (v1)
    Cc: Sargun Dhillon <sargun@sargun.me>
    Cc: Serge Hallyn <serge@hallyn.com>
    Cc: Jann Horn <jannh@google.com>
    Cc: Henning Schild <henning.schild@siemens.com>
    Cc: Andrei Vagin <avagin@gmail.com>
    Cc: Al Viro <viro@zeniv.linux.org.uk>
    Cc: Laurent Vivier <laurent@vivier.eu>
    Cc: linux-fsdevel@vger.kernel.org
    Acked-by: Serge Hallyn <serge@hallyn.com>
    Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
    Signed-off-by: Christian Brauner <brauner@kernel.org>
    Signed-off-by: Kees Cook <keescook@chromium.org>

Regards,
								Pavel
-- 
DENX Software Engineering GmbH,        Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

  reply	other threads:[~2024-08-29 12:11 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-27 14:35 Greg Kroah-Hartman
2024-08-27 17:46 ` Florian Fainelli
2024-08-27 18:07 ` Naresh Kamboju
2024-08-29 14:17   ` Greg Kroah-Hartman
2024-08-28  0:59 ` SeongJae Park
2024-08-28  3:02 ` Peter Schneider
2024-08-28 10:08 ` Pavel Machek
2024-08-28 11:37 ` Mark Brown
2024-08-28 14:34 ` Naresh Kamboju
2024-08-28 16:01 ` Miguel Ojeda
2024-08-28 18:24 ` Ron Economos
2024-08-29 11:37 ` Pavel Machek
2024-08-29 11:52   ` Greg Kroah-Hartman
2024-08-29 12:11     ` Pavel Machek [this message]
2024-08-29 13:43       ` Greg Kroah-Hartman
2024-08-29 13:47   ` Greg Kroah-Hartman
2024-08-29 12:07 ` Shreeya Patel
2024-08-31 21:19 ` Guenter Roeck
2024-09-01 16:01   ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZtBljcXHrUdvglG0@duo.ucw.cz \
    --to=pavel@denx.de \
    --cc=akpm@linux-foundation.org \
    --cc=allen.lkml@gmail.com \
    --cc=broonie@kernel.org \
    --cc=christian.brauner@ubuntu.com \
    --cc=conor@kernel.org \
    --cc=dsterba@suse.com \
    --cc=f.fainelli@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jonathanh@nvidia.com \
    --cc=keescook@chromium.org \
    --cc=kuba@kernel.org \
    --cc=linan122@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=lkft-triage@lists.linaro.org \
    --cc=patches@kernelci.org \
    --cc=patches@lists.linux.dev \
    --cc=rwarsow@gmx.de \
    --cc=shuah@kernel.org \
    --cc=song@kernel.org \
    --cc=srw@sladewatkins.net \
    --cc=stable@vger.kernel.org \
    --cc=sudipm.mukherjee@gmail.com \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®