mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: David Lin <yu-hao.lin@nxp.com>
Cc: Francesco Dolcini <francesco@dolcini.it>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"briannorris@chromium.org" <briannorris@chromium.org>,
	"kvalo@kernel.org" <kvalo@kernel.org>,
	Pete Hsieh <tsung-hsien.hsieh@nxp.com>
Subject: Re: [EXT] Re: [PATCH] wifi: mwifiex: avoid AP and STA running on different channel
Date: Fri, 30 Aug 2024 13:13:35 +0200	[thread overview]
Message-ID: <ZtGpX6dZQo3oywwT@pengutronix.de> (raw)
In-Reply-To: <PA4PR04MB963862022F22E473CD559310D1972@PA4PR04MB9638.eurprd04.prod.outlook.com>

On Fri, Aug 30, 2024 at 10:58:50AM +0000, David Lin wrote:
> > From: Sascha Hauer <s.hauer@pengutronix.de>
> > Sent: Friday, August 30, 2024 5:19 PM
> > To: Francesco Dolcini <francesco@dolcini.it>
> > Cc: David Lin <yu-hao.lin@nxp.com>; linux-wireless@vger.kernel.org;
> > linux-kernel@vger.kernel.org; briannorris@chromium.org; kvalo@kernel.org;
> > Pete Hsieh <tsung-hsien.hsieh@nxp.com>
> > Subject: [EXT] Re: [PATCH] wifi: mwifiex: avoid AP and STA running on
> > different channel
> > 
> > On Fri, Aug 30, 2024 at 10:10:30AM +0200, Francesco Dolcini wrote:
> > > +Sascha, that just sent a patch to handle the same issue.
> > >
> > > On Fri, Aug 30, 2024 at 11:06:30AM +0800, David Lin wrote:
> > > > Current firmware doesn't support AP and STA running on different
> > > > channels simultaneously.
> > > > FW crash would occur in such case.
> > > > This patch avoids the issue by disabling AP and STA to run on
> > > > different channels.
> > >
> > > Is this a generic issue of specific of some firmware version? Asking
> > > since the driver as you know is supporting multiple Wi-Fi device.
> > 
> > The driver does, unfortunately the hardware does not.
> > 
> > I learned this the hard way. When an accesspoint is running on uap0 and
> > you want to connect to an accesspoint on mlan0 then it won't work when
> > that accesspoint is on a different channel.
> > 
> > Likewise, when you are creating an accesspoint on uap0 using channel A and
> > another one on channel B then you'll notice that both accesspoints will end
> > up using channel A.
> > 
> > It took me a while to find that out. In the end I found the same channel
> > check in the nxpwifi driver.
> > 
> > Sascha
> > 
> 
> Yes, this patch is backported from nxpwifi (same as another patch for AP DFS mode).
> Because Mwifiex supports connect/disconnect and separate auth/assoc, I think I will
> clean up the code and create patch v2 later.

Gna, I didn't notice that I haven't answered to my own patch, but to
your patch addressing the same problem a few hours later ;)

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

  reply	other threads:[~2024-08-30 11:13 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-30  3:06 David Lin
2024-08-30  8:10 ` Francesco Dolcini
2024-08-30  8:19   ` [EXT] " David Lin
2024-08-30  9:18   ` Sascha Hauer
2024-08-30 10:58     ` [EXT] " David Lin
2024-08-30 11:13       ` Sascha Hauer [this message]
2024-08-30 11:25         ` David Lin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZtGpX6dZQo3oywwT@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=briannorris@chromium.org \
    --cc=francesco@dolcini.it \
    --cc=kvalo@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=tsung-hsien.hsieh@nxp.com \
    --cc=yu-hao.lin@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®