From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>
Cc: Liao Chen <liaochen4@huawei.com>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, gregkh@linuxfoundation.org,
jirislaby@kernel.org, joel@jms.id.au,
andrew@codeconstruct.com.au, andi.shyti@linux.intel.com,
florian.fainelli@broadcom.com, tglx@linutronix.de
Subject: Re: [PATCH -next] serial: 8250_aspeed_vuart: Enable module autoloading
Date: Tue, 3 Sep 2024 19:19:04 +0300 [thread overview]
Message-ID: <Ztc2-OuaL2IJI6QW@smile.fi.intel.com> (raw)
In-Reply-To: <4nyenalsjnerwjwcuk5zwm52rptnc5jhjhz3yhsmo7qt3gffhs@qadnsjic7p24>
On Tue, Sep 03, 2024 at 05:49:54PM +0200, Uwe Kleine-König wrote:
> On Tue, Sep 03, 2024 at 01:15:03PM +0000, Liao Chen wrote:
...
> I wonder if you found this entry missing by code review, or if you have
> a machine with that UART and so you actually benefit.
Using arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-rainier.dts in QEMU
I never experienced an issue. Seems due to defconfig having it =y.
(used arch/arm/configs/aspeed_g5_defconfig)
> Otherwise looks right to me.
>
> Acked-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-09-03 16:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-03 13:15 Liao Chen
2024-09-03 15:49 ` Uwe Kleine-König
2024-09-03 16:19 ` Andy Shevchenko [this message]
2024-09-06 2:04 ` liaochen (A)
2024-09-12 3:07 ` Andrew Jeffery
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ztc2-OuaL2IJI6QW@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=andi.shyti@linux.intel.com \
--cc=andrew@codeconstruct.com.au \
--cc=florian.fainelli@broadcom.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=joel@jms.id.au \
--cc=liaochen4@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®