From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: D Scott Phillips <scott@os.amperecomputing.com>
Cc: Catalin M arinas <catalin.marinas@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Will Deacon <will@kernel.org>, Ard Biesheuvel <ardb@kernel.org>,
linux-arm-kernel@lists.infradead.org,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
AKASHI Takahiro <takahiro.akashi@linaro.org>,
Alison Schofield <alison.schofield@intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
Andrey Konovalov <andreyknvl@gmail.com>,
Ankit Agrawal <ankita@nvidia.com>, Baoquan He <bhe@redhat.com>,
Dan Williams <dan.j.williams@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Wang Jinchao <wangjinchao@xfusion.com>,
linux-kernel@vger.kernel.org, patches@amperecomputing.com
Subject: Re: [PATCH v3] arm64: Expose the end of the linear map in PHYSMEM_END
Date: Tue, 3 Sep 2024 20:03:08 +0300 [thread overview]
Message-ID: <ZtdBTHzaeK4JNxvz@smile.fi.intel.com> (raw)
In-Reply-To: <20240903164532.3874988-1-scott@os.amperecomputing.com>
On Tue, Sep 03, 2024 at 09:45:32AM -0700, D Scott Phillips wrote:
> The memory hot-plug and resource management code needs to know the
> largest address which can fit in the linear map, so set
> PHYSMEM_END for that purpose.
>
> This fixes a crash[1] at boot when amdgpu tries to create
> DEVICE_PRIVATE_MEMORY and is given a physical address by the
> resource management code which is outside the range which can have
> a `struct page`
>
> The Fixes: commit listed below isn't actually broken, but the
> reorganization of vmemmap causes the improper DEVICE_PRIVATE_MEMORY address
> to go from a warning to a crash.
>
> [1]: Unable to handle kernel paging request at virtual address
No need to have [1]: prefix here and also read this
https://www.kernel.org/doc/html/latest/process/submitting-patches.html#backtraces-in-commit-messages
and amend commit message accordingly.
> 000001ffa6000034
> Mem abort info:
> ESR = 0x0000000096000044
> EC = 0x25: DABT (current EL), IL = 32 bits
> SET = 0, FnV = 0
> EA = 0, S1PTW = 0
> FSC = 0x04: level 0 translation fault
> Data abort info:
> ISV = 0, ISS = 0x00000044, ISS2 = 0x00000000
> CM = 0, WnR = 1, TnD = 0, TagAccess = 0
> GCS = 0, Overlay = 0, DirtyBit = 0, Xs = 0
> user pgtable: 4k pages, 48-bit VAs, pgdp=000008000287c000
> [000001ffa6000034] pgd=0000000000000000, p4d=0000000000000000
> Call trace:
> __init_zone_device_page.constprop.0+0x2c/0xa8
> memmap_init_zone_device+0xf0/0x210
> pagemap_range+0x1e0/0x410
> memremap_pages+0x18c/0x2e0
> devm_memremap_pages+0x30/0x90
> kgd2kfd_init_zone_device+0xf0/0x200 [amdgpu]
> amdgpu_device_ip_init+0x674/0x888 [amdgpu]
> amdgpu_device_init+0x7a4/0xea0 [amdgpu]
> amdgpu_driver_load_kms+0x28/0x1c0 [amdgpu]
> amdgpu_pci_probe+0x1a0/0x560 [amdgpu]
> local_pci_probe+0x48/0xb8
> work_for_cpu_fn+0x24/0x40
> process_one_work+0x170/0x3e0
> worker_thread+0x2ac/0x3e0
> kthread+0xf4/0x108
> ret_from_fork+0x10/0x20
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-09-03 17:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-03 16:45 D Scott Phillips
2024-09-03 17:03 ` Andy Shevchenko [this message]
2024-09-04 16:12 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZtdBTHzaeK4JNxvz@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=alison.schofield@intel.com \
--cc=andreyknvl@gmail.com \
--cc=ankita@nvidia.com \
--cc=ardb@kernel.org \
--cc=bhe@redhat.com \
--cc=catalin.marinas@arm.com \
--cc=dan.j.williams@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=patches@amperecomputing.com \
--cc=scott@os.amperecomputing.com \
--cc=takahiro.akashi@linaro.org \
--cc=wangjinchao@xfusion.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®