From: Johan Hovold <johan@kernel.org>
To: Riyan Dhiman <riyandhiman14@gmail.com>
Cc: srinivas.kandagatla@linaro.org, bgoswami@quicinc.com,
andersson@kernel.org, alsa-devel@alsa-project.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] soc: qcom: apr: Fix some parenthesis alignment coding style issues
Date: Wed, 4 Sep 2024 09:43:36 +0200 [thread overview]
Message-ID: <ZtgPqJHnQYd7Jm_z@hovoldconsulting.com> (raw)
In-Reply-To: <20240904054735.7952-1-riyandhiman14@gmail.com>
On Wed, Sep 04, 2024 at 11:17:35AM +0530, Riyan Dhiman wrote:
> Adhere to Linux kernel coding style.
>
> Issue reported by checkpatch:
> - CHECK: Alignment should match open parenthesis
This is not something that is part of the coding style and just an
excessive warning that that checkpatch issues when run with the
--pedantic (a.k.a. --strict) flag.
You can use that flag on your own code if you prefer, but don't send
"cleanups" like this for code that is already in the kernel. It's just
noise.
If you want to practise on how to create and submit a patch, these kind
of patches are accepted for code under drivers/staging however.
Johan
prev parent reply other threads:[~2024-09-04 7:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-04 5:47 Riyan Dhiman
2024-09-04 7:43 ` Johan Hovold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZtgPqJHnQYd7Jm_z@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=andersson@kernel.org \
--cc=bgoswami@quicinc.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=riyandhiman14@gmail.com \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®