From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Tommaso Merciai <tomm.merciai@gmail.com>
Cc: linuxfancy@googlegroups.com, michael.roeder@avnet.eu,
julien.massot@collabora.com,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/1] media: i2c: max96717: add test pattern ctrl
Date: Wed, 4 Sep 2024 13:03:50 +0000 [thread overview]
Message-ID: <ZthatrCgOKDwP7Ro@kekkonen.localdomain> (raw)
In-Reply-To: <ZthaMIMJykFLrOKC@tom-HP-ZBook-Fury-15-G7-Mobile-Workstation>
Hi Tommaso,
On Wed, Sep 04, 2024 at 03:01:36PM +0200, Tommaso Merciai wrote:
> On Wed, Sep 04, 2024 at 02:53:55PM +0200, Tommaso Merciai wrote:
> > Hi Sakari,
> > Sorry for delay and thanks for reviewing this.
No problem.
> >
> > On Wed, Aug 28, 2024 at 06:44:19AM +0000, Sakari Ailus wrote:
> > > > priv->sd.flags |= V4L2_SUBDEV_FL_HAS_DEVNODE | V4L2_SUBDEV_FL_STREAMS;
> > >
> > > With controls, you should add the HAS_EVENTS flag.
> > >
> > > I'll take this one as we're in rc5 already, please address these in a
> > > separate patch.
> >
> >
> > Will send a patch for this.
> > I think we should fix that also into max96717 driver or I'm wrong?
>
> max96714 sorry.
Yes, please.
--
Kind regards,
Sakari Ailus
prev parent reply other threads:[~2024-09-04 13:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240627151806.3999400-1-tomm.merciai@gmail.com>
2024-06-27 15:18 ` Tommaso Merciai
2024-06-27 16:10 ` Julien Massot
2024-08-28 6:44 ` Sakari Ailus
2024-09-04 12:53 ` Tommaso Merciai
2024-09-04 13:01 ` Tommaso Merciai
2024-09-04 13:03 ` Sakari Ailus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZthatrCgOKDwP7Ro@kekkonen.localdomain \
--to=sakari.ailus@linux.intel.com \
--cc=julien.massot@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linuxfancy@googlegroups.com \
--cc=mchehab@kernel.org \
--cc=michael.roeder@avnet.eu \
--cc=tomm.merciai@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®