From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Kaixin Wang <kxwang23@m.fudan.edu.cn>
Cc: sre@kernel.org, rdunlap@infradead.org,
linux-kernel@vger.kernel.org, 21210240012@m.fudan.edu.cn,
21302010073@m.fudan.edu.cn
Subject: Re: [PATCH v2] HSI: ssi_protocol: Fix use after free vulnerability in ssi_protocol Driver Due to Race Condition
Date: Mon, 16 Sep 2024 13:39:46 +0300 [thread overview]
Message-ID: <ZugK8hXvMaMEaOsz@smile.fi.intel.com> (raw)
In-Reply-To: <20240914172142.328-1-kxwang23@m.fudan.edu.cn>
On Sun, Sep 15, 2024 at 01:21:43AM +0800, Kaixin Wang wrote:
> In the ssi_protocol_probe function, &ssi->work is bound with
> ssip_xmit_work, In ssip_pn_setup, the ssip_pn_xmit function
> within the ssip_pn_ops structure is capable of starting the
> work.
We refer to the functions as func(). E.g., ssip_pn_setup(),
ssip_pn_xmit().
> If we remove the module which will call ssi_protocol_remove
> to make a cleanup, it will free ssi through kfree(ssi),
> while the work mentioned above will be used. The sequence
> of operations that may lead to a UAF bug is as follows:
>
> CPU0 CPU1
>
> | ssip_xmit_work
> ssi_protocol_remove |
> kfree(ssi); |
> | struct hsi_client *cl = ssi->cl;
> | // use ssi
>
> Fix it by ensuring that the work is canceled before proceeding
> with the cleanup in ssi_protocol_remove.
Same here.
...
> Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> - add the Acked-by label from Andy
Not that Ack was given to _this_ version of the change (it has been changed
a lot), but I'm fine with keeping it.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-09-16 10:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-14 17:21 Kaixin Wang
2024-09-16 10:39 ` Andy Shevchenko [this message]
2024-09-18 3:57 ` Kaixin Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZugK8hXvMaMEaOsz@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=21210240012@m.fudan.edu.cn \
--cc=21302010073@m.fudan.edu.cn \
--cc=kxwang23@m.fudan.edu.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®