mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Dr. David Alan Gilbert" <linux@treblig.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: David Hildenbrand <david@redhat.com>,
	linux-kernel@vger.kernel.org, kees@kernel.org
Subject: Re: Dead code by symbols
Date: Wed, 18 Sep 2024 10:55:32 +0000	[thread overview]
Message-ID: <ZuqxpBRVSYIk1Hkm@gallifrey> (raw)
In-Reply-To: <ZupwWT5ZEHFmWIXz@infradead.org>

* Christoph Hellwig (hch@infradead.org) wrote:
> On Tue, Sep 17, 2024 at 01:39:35PM +0200, David Hildenbrand wrote:
> > > Now, it does take some more guesswork, for example an unused function
> > > which was added a couple of years back, might be something that's
> > > there for consistency,
> > 
> > I know people will find reasons to do something like that, but we really
> > *shouldn't* be maintaining / dragging along dead code that nobody might ever
> > use.
> 
> There never is any reason to keep dead code around.

Yeh I mostly agree; and indeed I'll be sending many many patches to remove
the bucket loads of dead code I find; but as I say, there's a really
big variation from the dead-for-20 years, to relatively new, to 
functions that seem to make sense next to the file they're part of.
So I'll get to those later, I'll get rid of the very dead ones first.

Dave

> 
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/

  reply	other threads:[~2024-09-18 10:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-16 12:33 Dr. David Alan Gilbert
2024-09-17 11:39 ` David Hildenbrand
2024-09-17 12:15   ` Dr. David Alan Gilbert
2024-09-18  6:16   ` Christoph Hellwig
2024-09-18 10:55     ` Dr. David Alan Gilbert [this message]
2024-09-19  8:13       ` David Hildenbrand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZuqxpBRVSYIk1Hkm@gallifrey \
    --to=linux@treblig.org \
    --cc=david@redhat.com \
    --cc=hch@infradead.org \
    --cc=kees@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®