From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Parker Newman <parker@finest.io>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
Parker Newman <pnewman@connecttech.com>
Subject: Re: [PATCH v3 4/5] serial: 8250_exar: Remove old exar_ee_read() and other unneeded code
Date: Wed, 2 Oct 2024 17:29:47 +0300 [thread overview]
Message-ID: <Zv1Y2-KsGBQV1FX1@smile.fi.intel.com> (raw)
In-Reply-To: <9d3b61f6bf003206aebe4db9f32366cc8e214201.1727873292.git.pnewman@connecttech.com>
On Wed, Oct 02, 2024 at 10:14:10AM -0400, Parker Newman wrote:
> From: Parker Newman <pnewman@connecttech.com>
>
> Remove the old exar_ee_read() and associated helper functions.
> Remove defines that are no longer needed after the switch to using the
> eeprom_93cx6 driver.
> Add CTI_EE_MASK_OSC_FREQ define.
Seems like you have a rebase issues (you folded changes to the wrong patch).
...
> drivers/tty/serial/8250/8250_exar.c | 95 +----------------------------
> 1 file changed, 2 insertions(+), 93 deletions(-)
Shouldn't be + lines here.
...
> +#define CTI_EE_MASK_OSC_FREQ GENMASK(31, 0)
...
> osc_freq = le16_to_cpu(ee_words[0]) | (le16_to_cpu(ee_words[1]) << 16);
> - if (osc_freq == GENMASK(31, 0))
> + if (osc_freq == CTI_EE_MASK_OSC_FREQ)
> return -EIO;
You just introduced the - variant in the previous patch.
So, squash these two changes in the patch that adds this new conditional check.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-10-02 14:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-02 14:14 [PATCH v3 0/5] serial: 8250_exar: Replace custom EEPROM code with eeprom_93cx6 Parker Newman
2024-10-02 14:14 ` [PATCH v3 1/5] misc: eeprom: eeprom_93cx6: Add quirk for extra read clock cycle Parker Newman
2024-10-02 14:27 ` Andy Shevchenko
2024-10-02 14:14 ` [PATCH v3 2/5] misc: eeprom: eeprom_93cx6: Switch to BIT() macro Parker Newman
2024-10-02 14:14 ` [PATCH v3 3/5] serial: 8250_exar: Replace custom EEPROM read with eeprom_93cx6 Parker Newman
2024-10-02 14:14 ` [PATCH v3 4/5] serial: 8250_exar: Remove old exar_ee_read() and other unneeded code Parker Newman
2024-10-02 14:29 ` Andy Shevchenko [this message]
2024-10-02 14:14 ` [PATCH v3 5/5] serial: 8250_exar: Group CTI EEPROM offsets by device Parker Newman
2024-10-02 14:31 ` [PATCH v3 0/5] serial: 8250_exar: Replace custom EEPROM code with eeprom_93cx6 Andy Shevchenko
2024-10-02 14:37 ` Parker Newman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zv1Y2-KsGBQV1FX1@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=parker@finest.io \
--cc=pnewman@connecttech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®