From: Mary Strodl <mstrodl@freedom.csh.rit.edu>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Mary Strodl <mstrodl@csh.rit.edu>,
linux-kernel@vger.kernel.org, linus.walleij@linaro.org,
linux-gpio@vger.kernel.org
Subject: Re: [PATCH v3] gpio: add support for FTDI's MPSSE as GPIO
Date: Thu, 3 Oct 2024 12:08:44 -0400 [thread overview]
Message-ID: <Zv7BjPfA3rV8fUBH@freedom.csh.rit.edu> (raw)
In-Reply-To: <CAMRc=Mc+49C+GftT02HptPKYnrL+QidSB9fH2GC4yPecHqW4dQ@mail.gmail.com>
On Tue, Oct 01, 2024 at 09:04:58PM +0200, Bartosz Golaszewski wrote:
> I don't know much about the USB subsystem in the kernel, maybe Cc Greg
> KH on this?
Ok, I mostly just copied what I saw from other drivers.
> You could drop this label, all the gotos and the corresponding free in
> remove if you scheduled a devm action with devm_add_action_or_reset()
> right after getting the new index.
Thanks, didn't know about `devm_add_action_or_reset`! I was disappointed
to not find a `devm_ida_simple_get` when I wrote this, it is much cleaner
your way :)
> Overall it looks clean and nice but I can't tell if the USB-specific
> bits are correct.
>
> Bart
Thanks for the review! I sent out a v4 that should hopefully address your feedback.
- Mary
next prev parent reply other threads:[~2024-10-03 16:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-26 12:44 Mary Strodl
2024-10-01 19:04 ` Bartosz Golaszewski
2024-10-03 16:08 ` Mary Strodl [this message]
2024-10-02 13:31 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zv7BjPfA3rV8fUBH@freedom.csh.rit.edu \
--to=mstrodl@freedom.csh.rit.edu \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mstrodl@csh.rit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®