From: Oleksij Rempel <o.rempel@pengutronix.de>
To: Kory Maincent <kory.maincent@bootlin.com>
Cc: Simon Horman <horms@kernel.org>, Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Kyle Swenson <kyle.swenson@est.tech>,
thomas.petazzoni@bootlin.com,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH net] net: pse-pd: tps23881: Fix boolean evaluation for bitmask checks
Date: Tue, 24 Sep 2024 10:44:06 +0200 [thread overview]
Message-ID: <ZvJ71uWZygUxrmEo@pengutronix.de> (raw)
In-Reply-To: <20240924103357.1ca3d22f@kmaincent-XPS-13-7390>
On Tue, Sep 24, 2024 at 10:33:57AM +0200, Kory Maincent wrote:
> On Tue, 24 Sep 2024 09:26:12 +0100
> Simon Horman <horms@kernel.org> wrote:
>
> > > Don't know about it but if I can remove it from my driver it would be nice.
> > > :)
> >
> > Right, no question from my side that this change is a good one.
> > I'm just wondering if it is best for net or net-next.
>
> Indeed, I don't know the policy on this. Do you think it shouldn't go to net?
> I will let net maintainers decide. ;)
The net is always the right place for this kind of fixes. In any case, it
would be better to have actual symptoms of the issue addressed by
this patch in the commit message.
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2024-09-24 8:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-23 15:34 Kory Maincent
2024-09-24 6:17 ` Oleksij Rempel
2024-09-24 7:18 ` Simon Horman
2024-09-24 8:15 ` Kory Maincent
2024-09-24 8:26 ` Simon Horman
2024-09-24 8:33 ` Kory Maincent
2024-09-24 8:44 ` Oleksij Rempel [this message]
2024-09-24 8:56 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZvJ71uWZygUxrmEo@pengutronix.de \
--to=o.rempel@pengutronix.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kory.maincent@bootlin.com \
--cc=kuba@kernel.org \
--cc=kyle.swenson@est.tech \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®