From: Simona Vetter <simona.vetter@ffwll.ch>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Dave Airlie <airlied@gmail.com>, Sima Vetter <sima@ffwll.ch>,
dri-devel <dri-devel@lists.freedesktop.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [git pull] drm for 6.12-rc1
Date: Tue, 24 Sep 2024 13:51:43 +0200 [thread overview]
Message-ID: <ZvKnz7QzEe3jMbaH@phenom.ffwll.local> (raw)
In-Reply-To: <CAHk-=wiehYLXmbf8eZ080n7LEeS9=O5kEpGKjeP-01dj0EAYbA@mail.gmail.com>
On Thu, Sep 19, 2024 at 10:12:39AM +0200, Linus Torvalds wrote:
> On Thu, 19 Sept 2024 at 09:48, Dave Airlie <airlied@gmail.com> wrote:
> >
> > There are some minor conflicts with your tree but none seemed too
> > difficult to solve, let me know if there is any problems on your end.
>
> Christ. One of them is due to you guys being horrible at merging.
>
> Your tree had
>
> drm/xe/gt: Remove double include
>
> which removed (surprise surprise) a double instance of
>
> #include <generated/xe_wa_oob.h>
>
> but then in merge commit 4461e9e5c374 ("Merge v6.11-rc5 into
> drm-next") it got added back in!
>
> Please be more careful with your merges. You can't just look at the
> file contents, you have to look at the actual history of it to see
> what the *cause* of the conflict is.
Uh yeah not sure how I managed to butcher this one. I do check the history
with gitk --merge and then the result by both looking at the merge diff
and the new --remerge-diff output, and that merge looks like nonsense in
all but the last one. Which means I was asleep at the wheel when I did
that :-/
-Sima
--
Simona Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
next prev parent reply other threads:[~2024-09-24 11:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-19 7:48 Dave Airlie
2024-09-19 8:12 ` Linus Torvalds
2024-09-24 11:51 ` Simona Vetter [this message]
2024-09-19 9:10 ` pr-tracker-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZvKnz7QzEe3jMbaH@phenom.ffwll.local \
--to=simona.vetter@ffwll.ch \
--cc=airlied@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sima@ffwll.ch \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®