From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 985E8148849 for ; Wed, 25 Sep 2024 08:14:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727252084; cv=none; b=bzo1Z3eNWQ+vMXjGsYfMtsg/0uAYc0sCey8WAK73V6s483esKZ0hJbX4V6S1xjfLwANZUd2Bo9CBxiWQ3naQyZ9lnj652ybjhrVpf40JAcV0eoL2NYhWViCTHD9J9uZi0hhJlURODSOgENP2BBbQosw4bYO3PQxYefY6EG3ahew= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727252084; c=relaxed/simple; bh=BM4+PHT5MQW1tzpb5VK/c/ddqQXat3uRsnUaLXnXbio=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=LK4w3Md+L+O1W1ECUXhSJgOjwZA7IOIuzY76J9z+TSGTtnhRDoKN35dpHppNBKYlI+eDQzWOZSpyyAZ30Hm/2RKhoElJZddWmpz4NOdZlLMGpVtbunlN3n81yHU4cejXe5JP5+E2eee3Dp45/hrJROkJlFwnWZOmL4eZEuCdkf0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=NkWaqbgc; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="NkWaqbgc" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727252080; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ohfUwWhacb0visOzTSsijGJM7JyOseW65bAWIgeEGW8=; b=NkWaqbgcF9FcnmYAG5x7gQgaQvSyvdmfpbm4U0w6IugTmL18yVZy/Jsbsv+iE26pnk0aN5 ADc79vYN8fTfS3p+dnn7WOieKuaGpt+DETc27Rfr75xfCHaMjQJVhDf075lPo6xm1c9QoR lpr8VQ0vBIt5Q+hBTY3JtJ08m+A9VcY= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-587-L8wHNNPVOFKKiMc8OO59ig-1; Wed, 25 Sep 2024 04:14:38 -0400 X-MC-Unique: L8wHNNPVOFKKiMc8OO59ig-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-42cb115566eso59405955e9.2 for ; Wed, 25 Sep 2024 01:14:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727252077; x=1727856877; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ohfUwWhacb0visOzTSsijGJM7JyOseW65bAWIgeEGW8=; b=v+pyJl2Qrw6fNxW0BGh4cwV+e56Vt3pePWND8THmPXf/b9odwFc+ybS7JfMjuQQPjQ KPzmfg3PRJ9JtAkfj+GviFV6vSGeLiNt/S7UjWO3hh4h9LrftLHFqThvPsiZTc1jwek0 9uY1ugLGYBnBd1TsM4ZGeYV2xLGDVT4tljRU6Wk+6Ge8Hdf0IXpZpjmAYYxT96du/h35 J99cY/m7WiiNImc6zKm5lkRQzSzfYEeEK0/TlMD/QDHCk5GiOAU/RxkzDtnK+/zSjI3y p1+eaa+oV5n80aRoDv/Ya38tord41NutX6HAWf1JJTwnTreTg7QEL5ZLHKda2RDAvIbE vw7g== X-Forwarded-Encrypted: i=1; AJvYcCW1GYMg9fGceGxgO/nAzBA3uZyDR7Z+slPj+HGJwLn+sbiJlYLShmv6z22oajXO9Qhn5h4wI3LTWwZ/xzc=@vger.kernel.org X-Gm-Message-State: AOJu0YxcMl61VvX79WNu+f7tzT55zrdMVxfcl5W/RjeVrqKYAvXVQgW0 1sTuavBClFOV+62FftRVkBp+28Y9znUA912Y+HFvHtpmhe2D1THxXjNgDeJtRTxT6jeIBnpHa0c TZ4L+Xbn3dL5LdXZJjAeQPLWdmCQLaBDMtO/9szutNhH4FaqrTJuntb4fC8tjqopNyVs3Pw== X-Received: by 2002:a5d:4e0c:0:b0:374:c6af:1658 with SMTP id ffacd0b85a97d-37cc245d187mr1943060f8f.1.1727252077192; Wed, 25 Sep 2024 01:14:37 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEvvX0qsLkCUiC24qNlWQhIP1iZa0HBvfDgrX63bwheFNg//fcomFIcU8AuFJMGHgav4DSreQ== X-Received: by 2002:a5d:4e0c:0:b0:374:c6af:1658 with SMTP id ffacd0b85a97d-37cc245d187mr1943023f8f.1.1727252076661; Wed, 25 Sep 2024 01:14:36 -0700 (PDT) Received: from jlelli-thinkpadt14gen4.remote.csb ([151.29.135.242]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-37cbc31f3cesm3323261f8f.98.2024.09.25.01.14.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Sep 2024 01:14:35 -0700 (PDT) Date: Wed, 25 Sep 2024 10:14:33 +0200 From: Juri Lelli To: Christian Loehle Cc: "Rafael J. Wysocki" , "linux-kernel@vger.kernel.org" , linux-pm , Qais Yousef , Ingo Molnar , Viresh Kumar , Dietmar Eggemann , Pierre Gondois Subject: Re: [PATCH] cpufreq/schedutil: Only bind threads if needed Message-ID: References: <480f2140-ea59-4e1d-a68d-18cbcec10941@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Hi, On 12/09/24 17:01, Christian Loehle wrote: > On 9/12/24 16:41, Rafael J. Wysocki wrote: > > On Thu, Sep 12, 2024 at 3:53 PM Christian Loehle ... > >> diff --git a/kernel/sched/syscalls.c b/kernel/sched/syscalls.c > >> index c62acf509b74..7d4a4edfcfb9 100644 > >> --- a/kernel/sched/syscalls.c > >> +++ b/kernel/sched/syscalls.c > >> @@ -1159,6 +1159,9 @@ int dl_task_check_affinity(struct task_struct *p, const struct cpumask *mask) > >> if (!task_has_dl_policy(p) || !dl_bandwidth_enabled()) > >> return 0; > >> > >> + if (dl_entity_is_special(&p->dl)) > >> + return 0; > >> + > > > > Care to explain this particular piece? > > Looks suspicious but the truncated comment below explains it: > /* > * Since bandwidth control happens on root_domain basis, > * if admission test is enabled, we only admit -deadline > * tasks allowed to run on all the CPUs in the task's > * root_domain. > */ > So that would only allow setting it to all CPUs for the relevant > platforms unfortunately. > > That should be fine though since the sugov task is pretty much > a dummy in terms of bandwidth / admission control internally, so > no harm done to not enforce this when userspace wants to set > affinities. > ...Unless Juri disagrees. Nope, I agree. :) Wonder if we should put a comment along the lines of what you said above right above the new conditions (so that people will not need to wonder about it in the future). But not a strict requirement for me. Thanks! (and apologies for the delay in replying) Juri