From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 860953A8F7; Thu, 26 Sep 2024 13:25:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727357103; cv=none; b=c+3yg1+95HdNuo7z0ioC7d1kI4MLkdpaHx/9ptX8oiSBfvPzZ65bMtMpa6mMXXt6I9/61/1wKuuJNzcL6g3xmMxr29+T14ZEan9+Tr/xXYZIehjzFj6fdzTjutOCBQpTJx9Kfcay3/D/Q3SOPWLNFVep1i0j6jgulOe46BAwX9s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727357103; c=relaxed/simple; bh=V9RE/M+gbMJverjB0d1riqFqnVlY5qZURgqdDU9n43k=; h=Date:From:To:CC:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jzGzUPxbwSlRewwo7CIfRxB9n4cmLSRXqVPwskZ+gYZ3mO8w9Tyl85h1EpG9ebRGH4jAfeQBaPH1CduxhS+m9XYjOwWtfoWLzFgXZe6Hq6tfS5yDdpIMmOQUkuwfh/kFYuRnITPt5aKSnNSbVEXB5bYhc/Cur4wz6KnETrgEcbs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=jNFYLAM+; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="jNFYLAM+" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 48Q7Y0sq008702; Thu, 26 Sep 2024 13:24:43 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=R5l2Vl8aHn8BISv5XlT5lhXk lhnZr7wW2up5Cp71eMc=; b=jNFYLAM+B7aiP4/GbCTI/eKGOJFSBTJJTPRgcpIB x7l2KQCVbTlvQ3wU846CgH3NVm6lWEhx6lJtweAy1MZWZNoHSZm7siVx3FOJIVHA xGhU5ZFfV3sEc+GHt0NXXhJdJFSN0LFzYp2O0E4uRoy6yn7Ot3QnRZoeqPoK+v1j Z5TRCT6vN3tjCyX69NcBGrIrjyeKISGLo38AEPuvGu6XmhWosLRJJaroI9cGdGep amNf+tujJChJyWBbkyyZopMZpHxmea/EYpKw3YjF7D24Ywhp2XlTfkRZwtzx4hfz BlmAttG1O/ixsaTklq9TXIxOGxX0yNN4wQZTuXP5xX2Jbw== Received: from nalasppmta03.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 41snfh7tjq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 26 Sep 2024 13:24:43 +0000 (GMT) Received: from nalasex01c.na.qualcomm.com (nalasex01c.na.qualcomm.com [10.47.97.35]) by NALASPPMTA03.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTPS id 48QDOfwI002756 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 26 Sep 2024 13:24:41 GMT Received: from hu-bjorande-lv.qualcomm.com (10.49.16.6) by nalasex01c.na.qualcomm.com (10.47.97.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Thu, 26 Sep 2024 06:24:41 -0700 Date: Thu, 26 Sep 2024 06:24:40 -0700 From: Bjorn Andersson To: Mahadevan CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH v2 1/5] dt-bindings: display/msm: Document MDSS on SA8775P Message-ID: References: <20240926110137.2200158-1-quic_mahap@quicinc.com> <20240926110137.2200158-2-quic_mahap@quicinc.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20240926110137.2200158-2-quic_mahap@quicinc.com> X-ClientProxiedBy: nalasex01b.na.qualcomm.com (10.47.209.197) To nalasex01c.na.qualcomm.com (10.47.97.35) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: WpEB8sxuQbq_9Vrku2F-q9Hnql4jCzpI X-Proofpoint-GUID: WpEB8sxuQbq_9Vrku2F-q9Hnql4jCzpI X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1011 adultscore=0 lowpriorityscore=0 priorityscore=1501 malwarescore=0 mlxscore=0 suspectscore=0 impostorscore=0 spamscore=0 phishscore=0 mlxlogscore=999 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2408220000 definitions=main-2409260092 On Thu, Sep 26, 2024 at 04:31:33PM +0530, Mahadevan wrote: > Document the MDSS hardware found on the Qualcomm SA8775P platform. > > Signed-off-by: Mahadevan > --- > > [v2] > - Use fake DISPCC nodes to avoid clock dependencies in dt-bindings. [Dmitry] > - Update bindings by fixing dt_binding_check tool errors (update includes in example), > adding proper spacing and indentation in binding example, dropping unused labels, > dropping status disable, adding reset node. [Dmitry, Rob, Krzysztof] No concerns with the changelog, but please adopt b4 (go/upstream has instructions) for sending patches upstream. > > --- > .../display/msm/qcom,sa8775p-mdss.yaml | 239 ++++++++++++++++++ > 1 file changed, 239 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml > > diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml > new file mode 100644 > index 000000000000..e610b66ffa9f > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml > @@ -0,0 +1,239 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/msm/qcom,sa8775p-mdss.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm Technologies, Inc. SA87755P Display MDSS > + > +maintainers: > + - Mahadevan Please use Firstname Lastname, if possible > + > +description: > + SA8775P MSM Mobile Display Subsystem(MDSS), which encapsulates sub-blocks like > + DPU display controller, DP interfaces and EDP etc. > + > +$ref: /schemas/display/msm/mdss-common.yaml# > + [..] > + > +examples: > + - | > + #include > + #include > + #include > + #include > + #include > + #include > + > + display-subsystem@ae00000 { > + compatible = "qcom,sa8775p-mdss"; > + reg = <0 0x0ae00000 0 0x1000>; #address-cells and #size-cells are 1 in the example root node, so drop the two 0 entries. > + reg-names = "mdss"; > + > + /* same path used twice */ What do you mean? All three paths below are unique. > + interconnects = <&mmss_noc MASTER_MDP0 0 &mc_virt SLAVE_EBI1 0>, > + <&mmss_noc MASTER_MDP1 0 &mc_virt SLAVE_EBI1 0>, > + <&gem_noc MASTER_APPSS_PROC QCOM_ICC_TAG_ACTIVE_ONLY > + &config_noc SLAVE_DISPLAY_CFG QCOM_ICC_TAG_ACTIVE_ONLY>; > + interconnect-names = "mdp0-mem", > + "mdp1-mem", > + "cpu-cfg"; > + > + Regards, Bjorn