From: Nayeemahmed Badebade <nayeemahmed.badebade@sony.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Greg KH <gregkh@linuxfoundation.org>,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
rafael@kernel.org, yoshihiro.toyama@sony.com,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 0/2] Add framework for user controlled driver probes
Date: Fri, 27 Sep 2024 21:01:37 +0530 [thread overview]
Message-ID: <ZvbP2e8nZzjXKfVK@NAB-HP-ProDesk-600sony.com> (raw)
In-Reply-To: <43447165-37f9-4b35-ace6-8d32760f75a8@kernel.org>
On Thu, Sep 26, 2024 at 02:34:26PM +0200, Krzysztof Kozlowski wrote:
> On 26/09/2024 13:07, Nayeemahmed Badebade wrote:
> >>
> >>>> not required at the time of booting.
> >>>> Example: drivers/pci/controller/dwc/pci-imx6.c
> >>
> >> Just this one? I don't see anything obvious that can't turn that into a
> >> module, have you tried? What went wrong?
> >>
> >
> > Yes we have tried building it as a module.
> > This driver currently registers abort handler for pci using function
> > hook_fault_code() on arm. This function is not exported and marked with __init
> > tag. So we can't use it post boot.
>
> Then this is something to fix.
>
Thank you for the suggestion.
As per discussion in below link, its mentioned that hooks should be static and
should not change during runtime due to locking support not being there.
So its not safe to export this function to use in modules as per the comments
there.
We would appreciate any suggestions you might have on any possible
alternatives.
> > Also from past attempt made to modularize this driver in community, we saw the
> > hook is not safe to be used post boot.
> > Reference:
> > https://lore.kernel.org/linux-arm-kernel/1454889644-27830-2-git-send-email-paul.gortmaker@windriver.com/T/#m8995c6dcc40c54baef0665a7ee16d4209cb59655
>
>
> Best regards,
> Krzysztof
>
Thank you.
Regards,
Nayeem
next prev parent reply other threads:[~2024-09-27 15:04 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-11 14:23 Nayeemahmed Badebade
2024-09-11 14:23 ` [PATCH 1/2] dt-bindings: probe-control: add probe control driver Nayeemahmed Badebade
2024-09-17 9:00 ` Krzysztof Kozlowski
2024-09-26 9:40 ` Nayeemahmed Badebade
2024-09-11 14:23 ` [PATCH 2/2] driver: core: " Nayeemahmed Badebade
2024-09-12 20:46 ` Rob Herring
2024-09-17 8:55 ` Nayeemahmed Badebade
2024-09-18 14:55 ` Rob Herring
2024-09-26 10:06 ` Nayeemahmed Badebade
2024-09-13 4:37 ` Greg KH
2024-09-17 9:22 ` Nayeemahmed Badebade
2024-09-13 4:36 ` [PATCH 0/2] Add framework for user controlled driver probes Greg KH
2024-09-17 9:06 ` Nayeemahmed Badebade
2024-09-17 9:03 ` Krzysztof Kozlowski
2024-09-17 9:21 ` Greg KH
2024-09-26 11:07 ` Nayeemahmed Badebade
2024-09-26 12:34 ` Krzysztof Kozlowski
2024-09-27 15:31 ` Nayeemahmed Badebade [this message]
2024-09-27 17:36 ` Rob Herring
2024-09-30 7:12 ` Nayeemahmed Badebade
2024-09-17 10:11 ` Greg KH
2024-09-27 14:14 ` Nayeemahmed Badebade
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZvbP2e8nZzjXKfVK@NAB-HP-ProDesk-600sony.com \
--to=nayeemahmed.badebade@sony.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=yoshihiro.toyama@sony.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®