From: Namhyung Kim <namhyung@kernel.org>
To: Ian Rogers <irogers@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Kan Liang <kan.liang@linux.intel.com>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/4] perf stat: Fix affinity memory leaks on error path
Date: Tue, 1 Oct 2024 17:02:23 -0700 [thread overview]
Message-ID: <ZvyNj3_pf8r8oKk1@google.com> (raw)
In-Reply-To: <20241001052327.7052-2-irogers@google.com>
On Mon, Sep 30, 2024 at 10:23:24PM -0700, Ian Rogers wrote:
> Missed cleanup when an error occurs.
>
> Fixes: 49de179577e7 ("perf stat: No need to setup affinities when starting a workload")
> Signed-off-by: Ian Rogers <irogers@google.com>
> ---
> tools/perf/builtin-stat.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c
> index 1521b6df2606..3e6b9f216e80 100644
> --- a/tools/perf/builtin-stat.c
> +++ b/tools/perf/builtin-stat.c
> @@ -827,6 +827,7 @@ static int __run_perf_stat(int argc, const char **argv, int run_idx)
> }
> }
> affinity__cleanup(affinity);
> + affinity = NULL;
>
> evlist__for_each_entry(evsel_list, counter) {
> if (!counter->supported) {
> @@ -965,6 +966,7 @@ static int __run_perf_stat(int argc, const char **argv, int run_idx)
> if (forks)
> evlist__cancel_workload(evsel_list);
>
> + affinity__cleanup(affinity);
> return err;
Much better now, thanks!
Namhyung
> }
>
> --
> 2.46.1.824.gd892dcdcdd-goog
>
next prev parent reply other threads:[~2024-10-02 0:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-01 5:23 [PATCH v2 0/4] 2 leak fixes and lower 2 test fails to skips Ian Rogers
2024-10-01 5:23 ` [PATCH v2 1/4] perf stat: Fix affinity memory leaks on error path Ian Rogers
2024-10-02 0:02 ` Namhyung Kim [this message]
2024-10-01 5:23 ` [PATCH v2 2/4] perf test: Fix memory leaks on event-times error paths Ian Rogers
2024-10-01 5:23 ` [PATCH v2 3/4] perf test: Skip not fail tp fields test when insufficient permissions Ian Rogers
2024-10-01 5:23 ` [PATCH v2 4/4] perf test: Skip not fail syscall " Ian Rogers
2024-10-02 22:04 ` [PATCH v2 0/4] 2 leak fixes and lower 2 test fails to skips Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZvyNj3_pf8r8oKk1@google.com \
--to=namhyung@kernel.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®