mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Xiu Jianfeng <xiujianfeng@huaweicloud.com>
Cc: lizefan.x@bytedance.com, hannes@cmpxchg.org, mkoutny@suse.com,
	shuah@kernel.org, joshua.hahn6@gmail.com,
	cgroups@vger.kernel.org, linux-kselftest@vger.kernel.org,
	linux-kernel@vger.kernel.org, xiujianfeng@huawei.com
Subject: Re: [PATCH -next] selftests/cgroup: Fix compile error in test_cpu.c
Date: Mon, 14 Oct 2024 15:06:27 -1000	[thread overview]
Message-ID: <Zw3AE90cH8g8Blx4@slm.duckdns.org> (raw)
In-Reply-To: <20241011061153.107208-1-xiujianfeng@huaweicloud.com>

On Fri, Oct 11, 2024 at 06:11:53AM +0000, Xiu Jianfeng wrote:
> From: Xiu Jianfeng <xiujianfeng@huawei.com>
> 
> When compiling the cgroup selftests with the following command:
> 
> make -C tools/testing/selftests/cgroup/
> 
> the compiler complains as below:
> 
> test_cpu.c: In function ‘test_cpucg_nice’:
> test_cpu.c:284:39: error: incompatible type for argument 2 of ‘hog_cpus_timed’
>   284 |                 hog_cpus_timed(cpucg, param);
>       |                                       ^~~~~
>       |                                       |
>       |                                       struct cpu_hog_func_param
> test_cpu.c:132:53: note: expected ‘void *’ but argument is of type ‘struct cpu_hog_func_param’
>   132 | static int hog_cpus_timed(const char *cgroup, void *arg)
>       |                                               ~~~~~~^~~
> 
> Fix it by passing the address of param to hog_cpus_timed().
> 
> Fixes: 2e82c0d4562a ("cgroup/rstat: Selftests for niced CPU statistics")
> Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com>

Applied to cgroup/for-6.13.

Thanks.

-- 
tejun

      reply	other threads:[~2024-10-15  1:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-11  6:11 Xiu Jianfeng
2024-10-15  1:06 ` Tejun Heo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zw3AE90cH8g8Blx4@slm.duckdns.org \
    --to=tj@kernel.org \
    --cc=cgroups@vger.kernel.org \
    --cc=hannes@cmpxchg.org \
    --cc=joshua.hahn6@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=lizefan.x@bytedance.com \
    --cc=mkoutny@suse.com \
    --cc=shuah@kernel.org \
    --cc=xiujianfeng@huawei.com \
    --cc=xiujianfeng@huaweicloud.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®