mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Juri Lelli <juri.lelli@redhat.com>
To: Phil Auld <pauld@redhat.com>
Cc: linux-kernel@vger.kernel.org,
	Valentin Schneider <vschneid@redhat.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Dietmar Eggemann <dietmar.eggemann@arm.com>,
	Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH] sched/deadline: Use hrtick_enabled_dl() before start_hrtick_dl()
Date: Mon, 7 Oct 2024 08:12:47 +0100	[thread overview]
Message-ID: <ZwOJ781mpF137oT2@jlelli-thinkpadt14gen4.remote.csb> (raw)
In-Reply-To: <20241004123729.460668-1-pauld@redhat.com>

Hi Phil,

On 04/10/24 08:37, Phil Auld wrote:
> The deadline server code moved one of the start_hrtick_dl() calls
> but dropped the dl specific hrtick_enabled check. This causes hrticks
> to get armed even when sched_feat(HRTICK_DL) is false. Fix it.
> 
> Fixes: 63ba8422f876 ("sched/deadline: Introduce deadline servers")
> Signed-off-by: Phil Auld <pauld@redhat.com>
> Cc: Juri Lelli <juri.lelli@redhat.com>
> Cc: Valentin Schneider <vschneid@redhat.com>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: Dietmar Eggemann <dietmar.eggemann@arm.com>
> Cc: Steven Rostedt <rostedt@goodmis.org>

Indeed. Good catch!

Acked-by: Juri Lelli <juri.lelli@redhat.com>

Best,
Juri


  reply	other threads:[~2024-10-07  7:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-04 12:37 Phil Auld
2024-10-07  7:12 ` Juri Lelli [this message]
2024-10-12 14:16 ` [tip: sched/urgent] " tip-bot2 for Phil Auld

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZwOJ781mpF137oT2@jlelli-thinkpadt14gen4.remote.csb \
    --to=juri.lelli@redhat.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=pauld@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=vschneid@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®