From: Daniel Golle <daniel@makrotopia.org>
To: "Russell King (Oracle)" <linux@armlinux.org.uk>
Cc: Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 1/3] net: phy: realtek: read duplex and gbit master from PHYSR register
Date: Wed, 9 Oct 2024 12:54:18 +0100 [thread overview]
Message-ID: <ZwZu6rCtKf-A165a@makrotopia.org> (raw)
In-Reply-To: <ZwZUl1jG0bc2q8Le@shell.armlinux.org.uk>
On Wed, Oct 09, 2024 at 11:01:59AM +0100, Russell King (Oracle) wrote:
> On Wed, Oct 09, 2024 at 02:53:03AM +0100, Daniel Golle wrote:
> > -static void rtlgen_decode_speed(struct phy_device *phydev, int val)
> > +static void rtlgen_decode_physr(struct phy_device *phydev, int val)
> > {
> > - switch (val & RTLGEN_SPEED_MASK) {
> > + /* bit 2
> > + * 0: Link not OK
> > + * 1: Link OK
> > + */
> > + phydev->link = !!(val & RTL_VND2_PHYSR_LINK);
>
> Be careful with this. The link status bit in the BMSR is latched-low,
> meaning that it guarantees to inform the reader that the link failed at
> some point between the preceding read and current read.
>
> This is important to know, so code can react to a possibly different
> negotiation result (we must see a link-fail to recognise a different
> set of negotiation results.)
The datasheet calls that bit "Real Time Link Status".
If you think we should not use it, I will drop it.
prev parent reply other threads:[~2024-10-09 11:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-09 1:53 Daniel Golle
2024-10-09 1:54 ` [PATCH net-next 2/3] net: phy: realtek: change order of calls in C22 read_status() Daniel Golle
2024-10-09 1:55 ` [PATCH net-next 3/3] net: phy: realtek: clear 1000Base-T link partner advertisement Daniel Golle
2024-10-09 10:01 ` [PATCH net-next 1/3] net: phy: realtek: read duplex and gbit master from PHYSR register Russell King (Oracle)
2024-10-09 11:54 ` Daniel Golle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZwZu6rCtKf-A165a@makrotopia.org \
--to=daniel@makrotopia.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®