From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Jiri Kosina <jikos@kernel.org>
Cc: Thomas Kuehne <thomas.kuehne@gmx.li>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
llvm@lists.linux.dev, Benjamin Tissoires <bentiss@kernel.org>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Bill Wendling <morbo@google.com>,
Justin Stitt <justinstitt@google.com>
Subject: Re: [PATCH v1 1/1] HID: debug: Remove duplicates from 'keys'
Date: Wed, 16 Oct 2024 16:36:09 +0300 [thread overview]
Message-ID: <Zw_BSeDEZpTQTf6J@smile.fi.intel.com> (raw)
In-Reply-To: <nycvar.YFH.7.76.2410151419110.20286@cbobk.fhfr.pm>
On Tue, Oct 15, 2024 at 02:20:19PM +0200, Jiri Kosina wrote:
> On Thu, 5 Sep 2024, Andy Shevchenko wrote:
...
> > drivers/hid/hid-debug.c:3443:18: error: initializer overrides prior initialization of this subobject [-Werror,-Winitializer-overrides]
> > 3443 | [KEY_HANGEUL] = "HanGeul", [KEY_HANGUP_PHONE] = "HangUpPhone",
> > | ^~~~~~~~~
> > drivers/hid/hid-debug.c:3217:18: note: previous initialization is here
> > 3217 | [KEY_HANGUEL] = "Hangeul", [KEY_HANJA] = "Hanja",
> > | ^~~~~~~~~
> >
> > Fix this by removing them.
> >
> > The logic of removal is that, remove...
> > 1) if there is a constant that uses another defined constant, OR
> > 2) the one that appears later in the list.
...
> > - [KEY_HANGUEL] = "Hangeul", [KEY_HANJA] = "Hanja",
>
> The problem specifically with this one is really there to fix a typo
> someone did at some point in the past. See b9ab58dd8e771d ("Input: fix
> misspelling of Hangeul key").
>
> So I think we should preserve it somehow.
Right, I fixed that in v2 that has been just sent out.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2024-10-16 13:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-05 18:43 Andy Shevchenko
2024-10-08 19:06 ` Andy Shevchenko
2024-10-15 12:20 ` Jiri Kosina
2024-10-16 13:36 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zw_BSeDEZpTQTf6J@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bentiss@kernel.org \
--cc=jikos@kernel.org \
--cc=justinstitt@google.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=thomas.kuehne@gmx.li \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®