mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Johan Hovold <johan@kernel.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Johan Hovold <johan+linaro@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Abel Vesa <abel.vesa@linaro.org>,
	Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] arm64: dts: qcom: x1e80100: enable GICv3 ITS for PCIe
Date: Thu, 10 Oct 2024 16:02:51 +0200	[thread overview]
Message-ID: <Zwfei-Jn6goiya4H@hovoldconsulting.com> (raw)
In-Reply-To: <xwscnif4mqzykjinjtbr7jqsksy2buzindyttkk754jmumktm3@p5xxnmia7fxe>

On Thu, Oct 10, 2024 at 04:54:19PM +0300, Dmitry Baryshkov wrote:
> On Wed, Oct 09, 2024 at 06:17:15PM GMT, Johan Hovold wrote:
> > The DWC PCIe controller can be used with its internal MSI controller or
> > with an external one such as the GICv3 Interrupt Translation Service
> > (ITS).
> > 
> > Add the msi-map properties needed to use the GIC ITS. This will also
> > make Linux switch to the ITS implementation, which allows for assigning
> > affinity to individual MSIs. This specifically allows NVMe and Wi-Fi
> > interrupts to be processed on all cores (and not just on CPU0).
> > 
> > Note that using the GIC ITS on x1e80100 will cause Advanced Error
> > Reporting (AER) interrupts to be received on errors unlike when using
> > the internal MSI controller. Consequently, notifications about
> > (correctable) errors may now be logged for errors that previously went
> > unnoticed.
> > 
> > Also note that PCIe5 (and PCIe3) can currently only be used with the
> > internal MSI controller due to a platform (firmware) limitation.
> > 
> > Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> > ---
> > 
> > The PCIe Gen4 stability fixes [1] are now in 6.12-rc1 so that we can enable
> > the GIC ITS without being flooded with link error notifications [2].
> 
> Cc: <stable+noautosel@kernel.org> # Depends on driver stability fixes

This patch is enabling a new feature, it is not a fix, so Bjorn please
do not include the above tag when applying.

> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

But thanks for reviewing.

Johan

  reply	other threads:[~2024-10-10 14:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-09 16:17 Johan Hovold
2024-10-10 13:54 ` Dmitry Baryshkov
2024-10-10 14:02   ` Johan Hovold [this message]
2024-10-10 14:11     ` Dmitry Baryshkov
2024-10-10 14:16       ` Johan Hovold
2024-10-16 15:32 ` Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zwfei-Jn6goiya4H@hovoldconsulting.com \
    --to=johan@kernel.org \
    --cc=abel.vesa@linaro.org \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=johan+linaro@kernel.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®