From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Lee Jones <lee@kernel.org>
Cc: linux-kernel@vger.kernel.org,
platform-driver-x86@vger.kernel.org, linux-usb@vger.kernel.org,
"Hans de Goede" <hdegoede@redhat.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Heikki Krogerus" <heikki.krogerus@linux.intel.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
Subject: Re: [PATCH v2 0/4] mfd: intel_soc_pmic_bxtwc: Fix IRQ domain usage
Date: Thu, 10 Oct 2024 20:55:48 +0300 [thread overview]
Message-ID: <ZwgVJLLK2ldE_H4l@smile.fi.intel.com> (raw)
In-Reply-To: <172857714957.2687257.4921456811511949312.b4-ty@kernel.org>
On Thu, Oct 10, 2024 at 05:19:09PM +0100, Lee Jones wrote:
> On Sat, 05 Oct 2024 22:27:03 +0300, Andy Shevchenko wrote:
> > It appears that the driver has been developed without proper thinking
> > of what the difference between HW IRQ and Linux IRQ (also known as vIRQ).
> > This misunderstanding led to the 0 being used as vIRQ which is no-no and
> > platform APIs unveil this after the commit a85a6c86c25b ("driver core:
> > platform: Clarify that IRQ 0 is invalid"). With this the Intel Broxton
> > Whiskey Cove PMIC driver has to be fixed all over the places.
[...]
> Applied, thanks!
Thank you!
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2024-10-10 17:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-05 19:27 Andy Shevchenko
2024-10-05 19:27 ` [PATCH v2 1/4] mfd: intel_soc_pmic_bxtwc: Use IRQ domain for USB Type-C device Andy Shevchenko
2024-10-06 8:38 ` Greg Kroah-Hartman
2024-10-05 19:27 ` [PATCH v2 2/4] mfd: intel_soc_pmic_bxtwc: Use IRQ domain for TMU device Andy Shevchenko
2024-10-05 19:27 ` [PATCH v2 3/4] mfd: intel_soc_pmic_bxtwc: Use IRQ domain for PMIC devices Andy Shevchenko
2024-10-05 19:27 ` [PATCH v2 4/4] mfd: intel_soc_pmic_bxtwc: Fix IRQ domain names duplication Andy Shevchenko
2024-10-10 16:19 ` [PATCH v2 0/4] mfd: intel_soc_pmic_bxtwc: Fix IRQ domain usage Lee Jones
2024-10-10 17:55 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZwgVJLLK2ldE_H4l@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome