From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Javier Carrasco <javier.carrasco.cruz@gmail.com>
Cc: Prashant Malani <pmalani@chromium.org>,
Benson Leung <bleung@chromium.org>,
Guenter Roeck <groeck@chromium.org>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Enric Balletbo i Serra <eballetbo@kernel.org>,
chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] platform/chrome: cross_ec_type: fix missing fwnode reference decrement
Date: Fri, 11 Oct 2024 11:17:32 +0800 [thread overview]
Message-ID: <ZwiYzGzbfK4rmOxq@tzungbi-laptop> (raw)
In-Reply-To: <7767afd2-0ada-4cca-8861-ccdc874d555b@gmail.com>
On Wed, Oct 09, 2024 at 09:00:41PM +0200, Javier Carrasco wrote:
> On 09/10/2024 20:55, Javier Carrasco wrote:
> > By the way, I wonder why all error paths are redirected to the same
> > label to unregister ports, even before registering them (which seems to
> > be harmless because unregistered ports are ignored, but still). With this
I don't know the context a lot. But it looks like just a way to unregister
the registered ones in the error path.
> Small typo in the description, should be cross_ec_typec (last c is
> missing). I will fix that for v2, but I will wait for feedback and
> reviews to this first version.
Also cross -> cros. Otherwise, the fix looks good to me.
prev parent reply other threads:[~2024-10-11 3:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-09 18:55 Javier Carrasco
2024-10-09 19:00 ` Javier Carrasco
2024-10-11 3:17 ` Tzung-Bi Shih [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZwiYzGzbfK4rmOxq@tzungbi-laptop \
--to=tzungbi@kernel.org \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=eballetbo@kernel.org \
--cc=groeck@chromium.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=javier.carrasco.cruz@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pmalani@chromium.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®