mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Herbert Xu <herbert@gondor.apana.org.au>
To: Rosen Penev <rosenp@gmail.com>
Cc: linux-crypto@vger.kernel.org,
	"Boris Brezillon" <bbrezillon@kernel.org>,
	"Arnaud Ebalard" <arno@natisbad.org>,
	"Srujana Challa" <schalla@marvell.com>,
	"David S. Miller" <davem@davemloft.net>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"open list" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCHv2 4/5] crypto: cesa: move loop to mv_cesa_put_sram
Date: Fri, 18 Oct 2024 17:11:59 +0800	[thread overview]
Message-ID: <ZxImX3HsbFHD7vSl@gondor.apana.org.au> (raw)
In-Reply-To: <20241010194517.18635-5-rosenp@gmail.com>

On Thu, Oct 10, 2024 at 12:45:16PM -0700, Rosen Penev wrote:
>
> @@ -566,21 +572,16 @@ static int mv_cesa_probe(struct platform_device *pdev)
>  	return 0;
>  
>  err_cleanup:
> -	for (i = 0; i < caps->nengines; i++)
> -		mv_cesa_put_sram(pdev, i);
> -
> +	mv_cesa_put_sram(pdev);

I think it'd be cleaner if you introduced a new function that
did the loop and kept mv_cesa_put_sram as is.

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

  reply	other threads:[~2024-10-18  9:12 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-10 19:45 [PATCHv2 0/5] cesa: small cleanups Rosen Penev
2024-10-10 19:45 ` [PATCHv2 1/5] crypto: cesa: add COMPILE_TEST Rosen Penev
2024-10-10 19:45 ` [PATCHv2 2/5] crypto: cesa: use enabled variants for clk_get Rosen Penev
2024-10-10 19:45 ` [PATCHv2 3/5] crypto: cesa: remove irq_set_affinity_hint Rosen Penev
2024-10-10 19:45 ` [PATCHv2 4/5] crypto: cesa: move loop to mv_cesa_put_sram Rosen Penev
2024-10-18  9:11   ` Herbert Xu [this message]
2024-10-10 19:45 ` [PATCHv2 5/5] crypto: cesa: use devm_platform_get_and_ioremap_resource Rosen Penev
2024-10-19 11:58 ` [PATCHv2 0/5] cesa: small cleanups Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZxImX3HsbFHD7vSl@gondor.apana.org.au \
    --to=herbert@gondor.apana.org.au \
    --cc=arno@natisbad.org \
    --cc=bbrezillon@kernel.org \
    --cc=davem@davemloft.net \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rosenp@gmail.com \
    --cc=schalla@marvell.com \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®