Re: [PATCH net-next v3] net: Implement fault injection forcing skb reallocation

[Bagas Sanjaya <bagasdotme@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 2365 bytes --]

On Mon, Oct 14, 2024 at 06:50:00AM -0700, Breno Leitao wrote:
> +  To select the interface to act on, write the network name to the following file:
> +  `/sys/kernel/debug/fail_net_force_skb_realloc/devname`
"... write the network name to /sys/kernel/debug/fail_net_force_skb_realloc/devname."
> +  If this field is left empty (which is the default value), skb reallocation
> +  will be forced on all network interfaces.
> +
> <snipped>...
> +- /sys/kernel/debug/fail_net_force_skb_realloc/devname:
> +
> +        Specifies the network interface on which to force SKB reallocation.  If
> +        left empty, SKB reallocation will be applied to all network interfaces.
> +
> +        Example usage:
> +        # Force skb reallocation on eth0
> +        echo "eth0" > /sys/kernel/debug/fail_net_force_skb_realloc/devname
> +
> +        # Clear the selection and force skb reallocation on all interfaces
> +        echo "" > /sys/kernel/debug/fail_net_force_skb_realloc/devname

The examples rendered as normal paragraph instead (and look like long-running
sentences) so I wrap them in literal code blocks:

---- >8 ----
diff --git a/Documentation/fault-injection/fault-injection.rst b/Documentation/fault-injection/fault-injection.rst
index bb19638d53171b..b2bf3afd16d144 100644
--- a/Documentation/fault-injection/fault-injection.rst
+++ b/Documentation/fault-injection/fault-injection.rst
@@ -243,12 +243,13 @@ configuration of fault-injection capabilities.
         Specifies the network interface on which to force SKB reallocation.  If
         left empty, SKB reallocation will be applied to all network interfaces.
 
-        Example usage:
-        # Force skb reallocation on eth0
-        echo "eth0" > /sys/kernel/debug/fail_net_force_skb_realloc/devname
+        Example usage::
 
-        # Clear the selection and force skb reallocation on all interfaces
-        echo "" > /sys/kernel/debug/fail_net_force_skb_realloc/devname
+          # Force skb reallocation on eth0
+          echo "eth0" > /sys/kernel/debug/fail_net_force_skb_realloc/devname
+
+          # Clear the selection and force skb reallocation on all interfaces
+          echo "" > /sys/kernel/debug/fail_net_force_skb_realloc/devname
 
 Boot option
 ^^^^^^^^^^^

Thanks.

-- 
An old man doll... just what I always wanted! - Clara

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]