Hi! > >> > I'm guessing we can push this into 6.12-rc and the other patch into > >> > net-next. I'll toss it into net on Monday unless someone objects. > >> > >> Can you folks please at least wait until the maintainers of the code in > >> question had a look ? > > > > You are literally quoting the text where I say I will wait 3 more days. > > Unfortunately "until the maintainers respond" leads to waiting forever > > 50% of the time, and even when we cap at 3 working days we have 300 > > patches in the queue (292 right now, and I already spent 2 hours > > reviewing today). Hope you understand. > > I understand very well, but _I_ spent the time to review the earlier > variants of these patches and to debate with the submitter up to rev > 5. > > Now you go and apply a patch to a subsystem you do not even maintain just > because I did not have the bandwidth to look at it within the time > limit you defined? Seriously? > > This problem is there for years, so a few days +/- are absolutely not > relevant. > > > Sorry if we applied too early, please review, I'll revert if it's no > > good. It is no good :-( and it is now in stable. It needs to goto out in the error case, to permit cleanups. Best regards, Pavel +++ b/kernel/time/posix-clock.c @@ -312,6 +312,9 @@ static int pc_clock_settime(clockid_t id, const struct timespec64 *ts) goto out; } + if (!timespec64_valid_strict(ts)) + return -EINVAL; + if (cd.clk->ops.clock_settime) err = cd.clk->ops.clock_settime(cd.clk, ts); else -- People of Russia, stop Putin before his war on Ukraine escalates.