From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 62AB513AD3F for ; Tue, 22 Oct 2024 15:51:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729612290; cv=none; b=MGLIHY+foiCNvPhIk/QXXcV3xSmTAm/bjHjg2yagm4TjfrLhYO32trOlcCBqzqe+WkkB8HPmP0QCyPzVaKF+MO/Kv4d/OVv8M8RnTGnF8USPUq7XXBWMzULnHnRuwmaGDtADl/FnBCjFhmIIfmPatcI2SXsVlFH/KeMrlVVfVfA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729612290; c=relaxed/simple; bh=TGHjo7ux9zVk06eBs97w3tERf69Lss5aal67kmZ/qvM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=aclftkv1OEBwKtsutuFd/0mWgegulKrHXpKX27jRdzxzysSJGYyYAdaLUYWteDNL8vHig/uejETMNXx94m1rqd086VDh50h3gMYUh6qIUcvDzYvLVW/De1MDzVR79vZJMqjUug9c2l5q1mUyo75rCGePgEJPGQSeY2nBSLIJQ4o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=bAKEv18a; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="bAKEv18a" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 58066C4CEC3; Tue, 22 Oct 2024 15:51:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1729612288; bh=TGHjo7ux9zVk06eBs97w3tERf69Lss5aal67kmZ/qvM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bAKEv18aNEbvsQBh5hFl8/aXagEFU4NGr4xRcRvMjxC/B1Oj5Sy3wjcH/0HeIuw8L ixG6CcMItIKGkns2J5BUxItEJng76RDtNpgrXEK3rs/apDEOIpmJr7oDjVjr1oCORi m+Dxqfn3X+pcNqvVmfhPoCVfPfK7+LLGUVRPBo1Lt6qSDNRi3SAabZ+xfQXHlya8Yb mt0bImaaQL3RmQbQ2OMjDhNe1jtm8RsiSTZvsYca/S5CaIvWoETwu5w2oZ1sjpIp5h 9lT8KeDAgWjy2gnjnL/JIqE8UwUxxLcO9TTlZlxhZhY3kfDTCNuiqp7a1RxFt13Tjr MYIKmhxrGtC4w== Date: Tue, 22 Oct 2024 09:51:25 -0600 From: Keith Busch To: Sagi Grimberg Cc: Abhishek Bapat , Jens Axboe , Christoph Hellwig , Prashant Malani , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] nvme-sysfs: display max_hw_sectors_kb without requiring namespaces Message-ID: References: <20241016213108.549000-1-abhishekbapat@google.com> <6b00d25e-fe6a-4552-9945-d6181af83137@grimberg.me> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6b00d25e-fe6a-4552-9945-d6181af83137@grimberg.me> On Tue, Oct 22, 2024 at 06:35:11PM +0300, Sagi Grimberg wrote: > On 22/10/2024 17:53, Keith Busch wrote: > > On Thu, Oct 17, 2024 at 02:32:18PM -0700, Abhishek Bapat wrote: > > > > The request_queue is owned by the block layer, so that seems like an > > okay place to export it, but attached to some other device's sysfs > > directory instead of a gendisk. > > > > I'm just suggesting this because it doesn't sound like this is an nvme > > specific problem. > > Won't it be confusing to find queue/ directory in controller nvmeX sysfs > entry? It's the attributes of the request queue associated with that controller, so I think a queue/ directory under it makes sense. That's how it looks for gendisks, so why not for disk-less queues? Many queue attributes only make sense for gendisks, though, so maybe need to tweak visibility if we decide to do it like this.