From: Tony Luck <tony.luck@intel.com>
To: Zaid Alali <zaidal@os.amperecomputing.com>
Cc: rafael@kernel.org, lenb@kernel.org, james.morse@arm.com,
bp@alien8.de, robert.moore@intel.com, dan.j.williams@intel.com,
Jonathan.Cameron@huawei.com, Benjamin.Cheatham@amd.com,
Avadhut.Naik@amd.com, viro@zeniv.linux.org.uk, arnd@arndb.de,
ira.weiny@intel.com, dave.jiang@intel.com,
sthanneeru.opensrc@micron.com, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org, acpica-devel@lists.linux.dev
Subject: Re: [PATCH 4/8] ACPI: APEI: EINJ: Enable the discovery of EINJv2 capabilities
Date: Tue, 22 Oct 2024 15:10:59 -0700 [thread overview]
Message-ID: <Zxgi87DJvsUKTAyb@agluck-desk3.sc.intel.com> (raw)
In-Reply-To: <20241022213429.1561784-5-zaidal@os.amperecomputing.com>
On Tue, Oct 22, 2024 at 02:34:25PM -0700, Zaid Alali wrote:
> @@ -692,7 +704,7 @@ int einj_validate_error_type(u64 type)
> if (tval & (tval - 1))
> return -EINVAL;
> if (!vendor)
> - if (!(type & available_error_type))
> + if (!(type & (available_error_type)))
Extra parentheses around available_error_type not needed.
-Tony
next prev parent reply other threads:[~2024-10-22 22:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-22 21:34 [PATCH 0/8] Enable EINJv2 support Zaid Alali
2024-10-22 21:34 ` [PATCH 1/8] ACPICA: Update values to hex to follow ACPI specs Zaid Alali
2024-10-22 21:34 ` [PATCH 2/8] ACPICA: Add EINJv2 get error type action Zaid Alali
2024-10-22 21:34 ` [PATCH 3/8] ACPI: APEI: EINJ: Remove redundant calls to einj_get_available_error_type Zaid Alali
2024-10-22 21:34 ` [PATCH 4/8] ACPI: APEI: EINJ: Enable the discovery of EINJv2 capabilities Zaid Alali
2024-10-22 22:10 ` Tony Luck [this message]
2024-11-18 22:31 ` John Allen
2024-10-22 21:34 ` [PATCH 5/8] ACPI: APEI: EINJ: Add einjv2 extension struct Zaid Alali
2024-10-22 22:11 ` Tony Luck
2024-10-22 21:34 ` [PATCH 6/8] ACPI: APEI: EINJ: Add debugfs files for EINJv2 support Zaid Alali
2024-10-22 21:34 ` [PATCH 7/8] ACPI: APEI: EINJ: Enable EINJv2 error injections Zaid Alali
2024-10-24 8:33 ` kernel test robot
2024-11-18 22:20 ` John Allen
2024-10-22 21:34 ` [PATCH 8/8] ACPI: APEI: EINJ: Update the documentation for EINJv2 support Zaid Alali
2024-10-22 22:44 ` Tony Luck
2024-10-23 17:20 ` Tony Luck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zxgi87DJvsUKTAyb@agluck-desk3.sc.intel.com \
--to=tony.luck@intel.com \
--cc=Avadhut.Naik@amd.com \
--cc=Benjamin.Cheatham@amd.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=acpica-devel@lists.linux.dev \
--cc=arnd@arndb.de \
--cc=bp@alien8.de \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=ira.weiny@intel.com \
--cc=james.morse@arm.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=robert.moore@intel.com \
--cc=sthanneeru.opensrc@micron.com \
--cc=viro@zeniv.linux.org.uk \
--cc=zaidal@os.amperecomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome