Re: [PATCH] sched-ext: Use correct annotation for strings in kfuncs

[Tejun Heo <tj@kernel.org>]

On Mon, Oct 21, 2024 at 01:11:43PM -0700, Kumar Kartikeya Dwivedi wrote:
> The sched-ext kfuncs with bstr suffix need to take a string, but that
> requires annotating the parameters with __str suffix, as right now the
> verifier will treat this parameter as a one-byte memory region.
> 
> Fixes: f0e1a0643a59 ("sched_ext: Implement BPF extensible scheduler class")
> Fixes: 07814a9439a3 ("sched_ext: Print debug dump after an error exit")
> Cc: Tejun Heo <tj@kernel.org>
> Signed-off-by: Kumar Kartikeya Dwivedi <memxor@gmail.com>

I popped this patch from sched_ext/for-6.12-fixes along with the follow-up
fix. This breaks compatibility in a way which is difficult to work around.
If we want to do this, I think we should do it by introducing new set of
kfuncs and than phasing out the old ones. Also, it's unclear what the
practical benefits of the change are anyway.

Thanks.

-- 
tejun