From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>
Cc: Zeng Heng <zengheng4@huawei.com>,
jia-cheng.hu@intel.com, gregkh@linuxfoundation.org,
quic_jjohnson@quicinc.com, jinqian@android.com,
alan@linux.intel.com, linux-kernel@vger.kernel.org,
bobo.shaobowang@huawei.com
Subject: Re: [PATCH] goldfish: Fix unused const variable 'goldfish_pipe_acpi_match'
Date: Fri, 25 Oct 2024 17:32:13 +0300 [thread overview]
Message-ID: <Zxur7RC-bBYX79WJ@smile.fi.intel.com> (raw)
In-Reply-To: <ttlc5ppgljd3plbk6kw4ndi47pqafivtxk2sosdhlw3zeda273@dn74s3eluxqp>
On Fri, Oct 25, 2024 at 04:27:07PM +0200, Uwe Kleine-König wrote:
> On Fri, Oct 25, 2024 at 03:41:29PM +0800, Zeng Heng wrote:
> > Fix the following compilation warning:
> >
> > drivers/platform/goldfish/goldfish_pipe.c:925:36: warning:
> > ‘goldfish_pipe_acpi_match’ defined but not used
> > [-Wunused-const-variable=]
> > 925 | static const struct acpi_device_id goldfish_pipe_acpi_match[] = {
> >
> > Only define the const variable when the CONFIG_ACPI is enabled.
...
> Looking at changes like
> https://lore.kernel.org/all/20241024130424.3818291-11-andriy.shevchenko@linux.intel.com/
> I suggest to drop the use of ACPI_PTR() instead.
Right, please drop ACPI_PTR() and if needed, replace acpi.h with proper
mod_devicetable.h. You may find tons of examples in IIO:
`git log --grep ACPI_PTR -- drivers/iio`.
P.S. Thanks for Cc'ing me!
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-10-25 14:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-25 7:41 Zeng Heng
2024-10-25 14:27 ` Uwe Kleine-König
2024-10-25 14:32 ` Andy Shevchenko [this message]
2024-10-26 1:28 ` Zeng Heng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zxur7RC-bBYX79WJ@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=alan@linux.intel.com \
--cc=bobo.shaobowang@huawei.com \
--cc=gregkh@linuxfoundation.org \
--cc=jia-cheng.hu@intel.com \
--cc=jinqian@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_jjohnson@quicinc.com \
--cc=u.kleine-koenig@baylibre.com \
--cc=zengheng4@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®