From: Tejun Heo <tj@kernel.org>
To: David Vernet <void@manifault.com>
Cc: linux-kernel@vger.kernel.org, kernel-team@meta.com, sched-ext@meta.com
Subject: Re: [PATCH sched_ext/for-6.12-fixes] sched_ext: Make cast_mask() inline
Date: Fri, 25 Oct 2024 12:19:35 -1000 [thread overview]
Message-ID: <ZxwZd160pfdBYz2y@slm.duckdns.org> (raw)
In-Reply-To: <ZxwXgmKQ2B3OmIea@slm.duckdns.org>
On Fri, Oct 25, 2024 at 12:11:14PM -1000, Tejun Heo wrote:
> cast_mask() doesn't do any actual work and is defined in a header file.
> Force it to be inline. When it is not inlined and the function is not used,
> it can cause verificaiton failures like the following:
>
> # tools/testing/selftests/sched_ext/runner -t minimal
> ===== START =====
> TEST: minimal
> DESCRIPTION: Verify we can load a fully minimal scheduler
> OUTPUT:
> libbpf: prog 'cast_mask': missing BPF prog type, check ELF section name '.text'
> libbpf: prog 'cast_mask': failed to load: -22
> libbpf: failed to load object 'minimal'
> libbpf: failed to load BPF skeleton 'minimal': -22
> ERR: minimal.c:20
> Failed to open and load skel
> not ok 1 minimal #
> ===== END =====
>
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Fixes: a748db0c8c6a ("tools/sched_ext: Receive misc updates from SCX repo")
Applying to sched_ext/for-6.12-fixes.
Thanks.
--
tejun
prev parent reply other threads:[~2024-10-25 22:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-25 22:11 Tejun Heo
2024-10-25 22:19 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZxwZd160pfdBYz2y@slm.duckdns.org \
--to=tj@kernel.org \
--cc=kernel-team@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sched-ext@meta.com \
--cc=void@manifault.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®