From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 96B43233D65 for ; Fri, 8 Nov 2024 17:51:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731088289; cv=none; b=EHNIB3XjHGGSXP9EfXiIsYlwV5ntRR+evldsjm4vfJqZwakileh19UhkfYzcJdrKw7hO5rkXH0rDp3/rQ7mBmX0m20S+XQwzk4vdGpvSpetd9YWW+e9nKF4U/qoDafsmSLJapEp2mr4KR+2FWYOXF6rxET9+/kkmRS1H5VA4+qU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731088289; c=relaxed/simple; bh=/3MgB5TLL0Vh33RO3NR+19Owu0d0NzH9VQD0eANI+co=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fwcGj0fD2grtEmliGEDr4wa1SI3106A5+fx13q7d534+aJjs5WdhCAcmiXRKHG2ucIEzGVzngtvpAYnHxlbtgCedyFSpYc0yH+9v65++a0CGcXfRXr4dr0IJFFcBp1hzlRraTog/o7sbUO772upr1LIp2LFxTUstgiC0bRgvSi8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fastly.com; spf=pass smtp.mailfrom=fastly.com; dkim=pass (1024-bit key) header.d=fastly.com header.i=@fastly.com header.b=NekYr+UN; arc=none smtp.client-ip=209.85.210.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fastly.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fastly.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=fastly.com header.i=@fastly.com header.b="NekYr+UN" Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-71e4c2e36daso2231718b3a.0 for ; Fri, 08 Nov 2024 09:51:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastly.com; s=google; t=1731088287; x=1731693087; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=Pht2Zfqt18dy8oouut94+j6Gl4HetGZZdTUCc/od8bE=; b=NekYr+UNjyvSfFRdnSukq6VrJBEyFXr3YCpsQhoqeS302UVszg/eBaBdkUysqOWiXl TYWYz9Xwux43PPyE6LZp01HJkNfa2uCA99x2x7H/cTvTphahIdl+c6tDKPNv/ZHlSV3i tnDs17AUwiOyx6sLMMXMb3mj6JX+2gNSvmgCE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731088287; x=1731693087; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Pht2Zfqt18dy8oouut94+j6Gl4HetGZZdTUCc/od8bE=; b=fOG53aBauPGI8LZ6ceygvHtFAC7AvICQbsf3/nqzSKfKQnXEGwcMDJQ6w7U2ixiZUx mRdHVxHZSC37P75XxdePAQgcH4dwNSFiOc8DN2N+vh+5d+BQZKWyqT110vP0IVu8Hjcs hdXpsOn8q0XPbcYBH6lD9XeYGVMd9QZOsN2clri9XQFojnHgVKOymhjwUywiGKUNTAXX 6swORLRVMlIFuNApfrdmcr3XMUVnCPB8mox1CHTDnKf2NKcyukpeFCrxpQni5Gj9zJAa bvFJWQfcOyne6AS2y5UA+G8aYNqs7nnfgWAi6KqSHbQYhXV898PSbRxFNfagshHOlDx9 0LGA== X-Forwarded-Encrypted: i=1; AJvYcCXArn9G/IzWpiE2m63UdN4FViPGInIzBqhreEe9/H2WMmFZNunGbsCfd09rmid0MJ1YZrdy3B5Dz5PGjpY=@vger.kernel.org X-Gm-Message-State: AOJu0YzepGH+0Y5E2H257bRsjx2zIGVtUXMYjwX+cCAXFnqwwj9n6qfm dbxtUNLoUM/xhhB2QpJb/nMcOk8gLwNZVYUrSAct+XK3gbrfXEFZ6igV+O/pxBw= X-Google-Smtp-Source: AGHT+IGya6rez+EHBKo0lFA7BET3pZeXAAEZswqdwH3MspfleBVeZZPvdMVfY532zCLASQ5HjtRSzQ== X-Received: by 2002:a05:6a21:3391:b0:1d3:418a:e42 with SMTP id adf61e73a8af0-1dc23321c26mr5288160637.10.1731088286959; Fri, 08 Nov 2024 09:51:26 -0800 (PST) Received: from LQ3V64L9R2 (c-24-6-151-244.hsd1.ca.comcast.net. [24.6.151.244]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72407991bc8sm4021561b3a.96.2024.11.08.09.51.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Nov 2024 09:51:26 -0800 (PST) Date: Fri, 8 Nov 2024 09:51:23 -0800 From: Joe Damato To: Willem de Bruijn Cc: netdev@vger.kernel.org, corbet@lwn.net, hdanton@sina.com, bagasdotme@gmail.com, pabeni@redhat.com, namangulati@google.com, edumazet@google.com, amritha.nambiar@intel.com, sridhar.samudrala@intel.com, sdf@fomichev.me, peter@typeblog.net, m2shafiei@uwaterloo.ca, bjorn@rivosinc.com, hch@infradead.org, willy@infradead.org, skhawaja@google.com, kuba@kernel.org, Martin Karsten , "David S. Miller" , Simon Horman , Shuah Khan , open list , "open list:KERNEL SELFTEST FRAMEWORK" Subject: Re: [PATCH net-next v8 5/6] selftests: net: Add busy_poll_test Message-ID: Mail-Followup-To: Joe Damato , Willem de Bruijn , netdev@vger.kernel.org, corbet@lwn.net, hdanton@sina.com, bagasdotme@gmail.com, pabeni@redhat.com, namangulati@google.com, edumazet@google.com, amritha.nambiar@intel.com, sridhar.samudrala@intel.com, sdf@fomichev.me, peter@typeblog.net, m2shafiei@uwaterloo.ca, bjorn@rivosinc.com, hch@infradead.org, willy@infradead.org, skhawaja@google.com, kuba@kernel.org, Martin Karsten , "David S. Miller" , Simon Horman , Shuah Khan , open list , "open list:KERNEL SELFTEST FRAMEWORK" References: <20241108045337.292905-1-jdamato@fastly.com> <20241108045337.292905-6-jdamato@fastly.com> <672e26ec429be_2a4cd22944c@willemb.c.googlers.com.notmuch> <672e4ea4e979a_2bc2f629490@willemb.c.googlers.com.notmuch> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <672e4ea4e979a_2bc2f629490@willemb.c.googlers.com.notmuch> On Fri, Nov 08, 2024 at 12:47:16PM -0500, Willem de Bruijn wrote: > Joe Damato wrote: > > On Fri, Nov 08, 2024 at 09:57:48AM -0500, Willem de Bruijn wrote: > > > Joe Damato wrote: > > > > Add an epoll busy poll test using netdevsim. > > > > > > > > This test is comprised of: > > > > - busy_poller (via busy_poller.c) > > > > - busy_poll_test.sh which loads netdevsim, sets up network namespaces, > > > > and runs busy_poller to receive data and socat to send data. > > > > > > > > The selftest tests two different scenarios: > > > > - busy poll (the pre-existing version in the kernel) > > > > - busy poll with suspend enabled (what this series adds) > > > > > > > > The data transmit is a 1MiB temporary file generated from /dev/urandom > > > > and the test is considered passing if the md5sum of the input file to > > > > socat matches the md5sum of the output file from busy_poller. > > > > > > Nice test. > > > > > > Busy polling does not affect data integrity. Is the goal of this test > > > mainly to get coverage, maybe observe if the process would stall > > > indefinitely? > > > > Just to get coverage and make sure data makes it from point A to > > point B intact despite suspend being enabled. > > > > The last paragraph of the commit message highlights that netdevsim > > functionality is limited, so the test uses what is available. It can > > be extended in the future, when netdevsim supports more > > functionality. > > > > Paolo wanted a test and this is the best test we can provide given > > the limitations of the testing environment. > > > > > > netdevsim was chosen instead of veth due to netdevsim's support for > > > > netdev-genl. > > > > > > > > For now, this test uses the functionality that netdevsim provides. In the > > > > future, perhaps netdevsim can be extended to emulate device IRQs to more > > > > thoroughly test all pre-existing kernel options (like defer_hard_irqs) > > > > and suspend. > > > > [...] > > > > The rest of the feedback below seems pretty minor; I don't think > > it's worth spinning a v9 and re-sending just for this. > > > > If anything this can be handled with a clean up commit in the > > future. > > FWIW no objections from me. Thanks. > > Jakub: please let me know if you prefer to see a v9 for this?