From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f177.google.com (mail-qk1-f177.google.com [209.85.222.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C00F5204013 for ; Tue, 29 Oct 2024 13:20:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730208044; cv=none; b=kGpz5leP6nL7czj4ZE4ceQrgJD7RVYKA/5154kOrBIHJxExhVJkIo/81m/zOEzPD7bgQdR0kaNZGYe2bGK0WJ3GX4/XXmYgL9T19QPhzNUa5J4uZs0H1HDHGJtu0712Qm1xbGiKi2kAB9NHCi0tv6Snfq+j6kiimf4ROZS0+Hp0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730208044; c=relaxed/simple; bh=0Rw57/ngh3X2LN6V+OXc0GKTZffQMRd48D8zHGpjNug=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=J5Djk6EvNcR8kwa8tjMSwsahIitfcWpxsPA/D8q/2ZjESKZoTsKr5PE7+pYQJQY/uQ1naHWpUxcnfm1lg8yatZQjqdqiTWXaZfyzG9kh62lN5C/XTlWMrrMihbPy8caAi+w4KP0J1e/ts7PyCq0JrWOLo3q9mZou5l3lMhfPkuo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net; spf=pass smtp.mailfrom=gourry.net; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b=SiRaQ6JE; arc=none smtp.client-ip=209.85.222.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gourry.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b="SiRaQ6JE" Received: by mail-qk1-f177.google.com with SMTP id af79cd13be357-7b13ff3141aso417159785a.1 for ; Tue, 29 Oct 2024 06:20:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1730208041; x=1730812841; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=X13QuMz4ULWUYaYEjbvcdDk+axoVrdNmaWAMXcQKv4E=; b=SiRaQ6JEMQa6ZZ1yqx72cMKwyEPQNvBK/kz2f40yR1QZylStTnSujCAagyERp5HXgD IZ5v9tFgdHXNLxoXHlnDPLNudynqMC+cmcQAeuq7eYNb9caIoRO/CMLmsjD/AlVVcp+z +EOnS+87sybIe68R3tB3YP76YuafsKMHmyYwGHJzwSZzIj8Q0yMeIPr40C9ogssSCZDy sGnZQuCjj6b0Y78iY6BCcua1yZvj/CnPtrwfmEPGr0a/10l0qtSWQGIWlKu5832O83fo 19GpJW6N28kfDy7opKFT0LDqb9QDTSB+A5/LBnmesUY/TgzckYq/biPTVRddTywFy+5a Nc2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730208041; x=1730812841; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=X13QuMz4ULWUYaYEjbvcdDk+axoVrdNmaWAMXcQKv4E=; b=vtMuHFTgLgOcCgbA49TUQybpfJqTMjahpfauoz7OeBbpe4aiaJuo5fJzZxSwZoQF4N Wfhaf9xtTpr96N2MyxZN39OYL4i8I7HumQFgfJE91GHMH7DIQTV3C3QHv885w4V0Nm8Z QQxEnwGh/9PysQuU4HoAFgM1xOMN9HEIFfAi/RzZS5l4AZrI5NBltlrSTZGr5MoRidsM 8lwjDghXWHKyc3M1T00gUa+UQdmdNtQo+XVEHlcv3BLppjFOBRK524MXPZMpzq97ugqa bQ3T/vjUyOkDzvkxbjjib08kjP+c4XRjI5D7kWe8WkXyRRr1EX8FtUlpeoeWT9hE0Enh 1New== X-Forwarded-Encrypted: i=1; AJvYcCUufi7MahJ+zRB2x8vT1xCXuiAAFBjFLp/ugw3spjr8b4/ZPq9/ng80Bn2obgBh3qjjj/Eu90mMDGlaVMU=@vger.kernel.org X-Gm-Message-State: AOJu0YwWXEZg1hrLtSObmEgD7BTFl3yfgtr/0mcMZIIN6Xss6h0pYE8S DmiCbJGCqquEDTcwvscetbwjPrGwtSyv2iibAb20wyK3a5N//9Ytc2Iq6JkzPWw= X-Google-Smtp-Source: AGHT+IHhg5v3TWiRx6aq9mSkPnfzEXY2e0MobJKbVOXNsfSKLR6G02+D9thPPmKmqRlxnYDQq09kuw== X-Received: by 2002:a05:620a:1725:b0:7b1:4948:109f with SMTP id af79cd13be357-7b193f650abmr1528422385a.57.1730208040698; Tue, 29 Oct 2024 06:20:40 -0700 (PDT) Received: from PC2K9PVX.TheFacebook.com (pool-173-79-56-208.washdc.fios.verizon.net. [173.79.56.208]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7b18d32c9e3sm413535685a.80.2024.10.29.06.20.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Oct 2024 06:20:40 -0700 (PDT) Date: Tue, 29 Oct 2024 09:20:44 -0400 From: Gregory Price To: David Hildenbrand Cc: x86@kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-mm@kvack.org, linux-cxl@kvack.org, Jonathan.Cameron@huawei.com, dan.j.williams@intel.com, rrichter@amd.com, Terry.Bowman@amd.com, dave.jiang@intel.com, ira.weiny@intel.com, alison.schofield@intel.com, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, rafael@kernel.org, lenb@kernel.org, osalvador@suse.de, gregkh@linuxfoundation.org, akpm@linux-foundation.org, rppt@kernel.org Subject: Re: [PATCH v3 3/3] acpi,srat: give memory block size advice based on CFMWS alignment Message-ID: References: <20241022213450.15041-1-gourry@gourry.net> <20241022213450.15041-4-gourry@gourry.net> <55a5b63a-a6bb-4ba0-9aad-c9d8741d1c3a@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55a5b63a-a6bb-4ba0-9aad-c9d8741d1c3a@redhat.com> On Tue, Oct 29, 2024 at 01:42:12PM +0100, David Hildenbrand wrote: > > > static int __init acpi_parse_cfmws(union acpi_subtable_headers *header, > > void *arg, const unsigned long table_end) > > { > > @@ -545,6 +569,15 @@ int __init acpi_numa_init(void) > > * Initialize a fake_pxm as the first available PXM to emulate. > > */ > > + /* Align memblock size to CFMW regions if possible */ > > + acpi_table_parse_cedt(ACPI_CEDT_TYPE_CFMWS, acpi_align_cfmws, NULL); > > + > > + /* > > + * Nodes start populating with blocks after this, so probe the max > > + * block size to prevent it from changing in the future. > > + */ > > + memory_block_probe_max_size(); > > + > > This looks odd. Why shouldn't we allow someone else to suggest/advise an > even smaller "max size" ? I'd drop that. > Ah, my reading of the numa_add_memblk path was mistaken. I thought the hotplug blocks would start being created immediately after this in the acpi_parse_cfmws path - but memblk != memory_block x_x. Will drop along with other recommended updates and submit v4. ~Gregory